Re: [PATCH] pinctrl: Explicitly include correct DT includes

Emil Renner Berthing
2023-07-17T09:00:12Z

On Fri, 14 Jul 2023 at 19:52, Rob Herring <robh@kernel.org> wrote:
>
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

> drivers/pinctrl/starfive/pinctrl-starfive-jh7110-aon.c | 5 +----
> drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c | 2 --
> drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c | 1 -

Acked-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>

Thanks,
/Emil