From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 95C0CAD37 for ; Fri, 4 Aug 2023 13:35:43 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6705A1007; Fri, 4 Aug 2023 06:36:25 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 653133F5A1; Fri, 4 Aug 2023 06:35:39 -0700 (PDT) Date: Fri, 4 Aug 2023 14:35:37 +0100 From: Andre Przywara To: Martin Botka Cc: martin.botka1@gmail.com, Konrad Dybcio , AngeloGioacchino Del Regno , Marijn Suijten , Jami Kettunen , Paul Bouchara , Martin Botka , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andrew Lunn , Icenowy Zheng , Ludwig Kormann , Heiko Stuebner , Shawn Guo , Bjorn Andersson , Chris Morgan , Jagan Teki , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support Message-ID: <20230804143537.0c91e802@donnerap.manchester.arm.com> In-Reply-To: <92B0AD8F9717BDE3+20230804090102.273029-5-martin@biqu3d.com> References: <20230804090102.273029-1-martin@biqu3d.com> <92B0AD8F9717BDE3+20230804090102.273029-5-martin@biqu3d.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 4 Aug 2023 11:00:32 +0200 Martin Botka wrote: Hi, > The BigTreeTech Pi is an H616 based board based on CB1. > Just in Rpi format board. > > It features the same internals as BTT CB1 but adds: > - Fan port > - IR receiver > - ADXL345 Accelerometer connector via SPI > - 24V DC power supply via terminal plugs > - USB to CAN module connector (The actual USB to CAN happens on the external module) > > List of currently working things is same as BTT CB1 but also: > - IR receiver > - ADXL345 connector > > Signed-off-by: Martin Botka > --- > Changes in V2: > - Add UART alongside aliases and chosen for it > - Add model string > - Enable IR receiver > - Enable SPI0 for ADXL345 connector > > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../allwinner/sun50i-h616-bigtreetech-pi.dts | 68 +++++++++++++++++++ > 2 files changed, 69 insertions(+) > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > index 7b386428510b..0b6232a7f328 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-model-b.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > new file mode 100644 > index 000000000000..cbeedf147ab6 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > @@ -0,0 +1,68 @@ > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > +/* > + * Copyright (C) 2023 Martin Botka . > + */ > + > +/dts-v1/; > + > +#include "sun50i-h616-bigtreetech-cb1.dtsi" > + > +/ { > + model = "BigTreeTech Pi" missing semicolon > + compatible = "bigtreetech,pi", "allwinner,sun50i-h616"; > + > + aliases { > + serial0 = &uart0; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > +}; > + > +&ehci0 { > + status = "okay"; > +}; > + > +&ehci1 { > + status = "okay"; > +}; > + > +&ehci2 { > + status = "okay"; > +}; > + > +&ehci3 { > + status = "okay"; > +}; > + > +&ir { > + status = "okay"; > +}; > + > +&ohci0 { > + status = "okay"; > +}; > + > +&ohci1 { > + status = "okay"; > +}; > + > +&ohci2 { > + status = "okay"; > +}; > + > +&ohci3 { > + status = "okay"; > +}; > + > +&spi0 { > + /* SPI connection for onboard connector for ADXL345 accelerometer */ You need to specify the pinctrl properties here, since there is no default. I guess it's PortC? Then you can copy from the OPiZero2, just check the CS situation. > + status = "okay"; > +} missing semicolon; Rest looks fine. Thanks, Andre > + > +&uart0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart0_ph_pins>; > + status = "okay"; > +};