From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAC078BEC; Sun, 12 Nov 2023 13:24:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G4gasymp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2366C433D9; Sun, 12 Nov 2023 13:24:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699795498; bh=fA/Gl85/aqYKqIqYNvGeoHYQKLCcLZ+PRdv4RZjBolk=; h=From:To:Cc:Subject:Date:From; b=G4gasympdwV0LTZFszLaEsnVxur1LcQ9mupuXVEF/d/u0In3xvHjHyDe+C23ARXlP /oZUWp+4Y4eJ7VKnFFmOrykf84ss0pTRAlDmh5ooE8bLeVVVGXKp3mc+WIsLeXO4LV Vay3bn2vp5PLMR0uB0HZsKOgXZXHwoRAulBaZAPbTshvWuTZJyWu3OmsyYZPCLXumN K6oQX5bIdbFQajlWbvbvqsYtukbj4BEY0/WnDoaW4dIFkPOyl7kzLkwxf7azfM4fW3 TK4M5fy/TS5AaczRg3zrpmSDNWlL5IQozQtzZPdr+TBCLlGiHjuxAb7APcJDTHY2up 21c10MbWUfx+A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Axel Lin , Boris Brezillon , Wolfram Sang , Sasha Levin , andi.shyti@kernel.org, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH AUTOSEL 4.14] i2c: sun6i-p2wi: Prevent potential division by zero Date: Sun, 12 Nov 2023 08:24:54 -0500 Message-ID: <20231112132454.174917-1-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.14.329 Content-Transfer-Encoding: 8bit From: Axel Lin [ Upstream commit 5ac61d26b8baff5b2e5a9f3dc1ef63297e4b53e7 ] Make sure we don't OOPS in case clock-frequency is set to 0 in a DT. The variable set here is later used as a divisor. Signed-off-by: Axel Lin Acked-by: Boris Brezillon Signed-off-by: Wolfram Sang Signed-off-by: Sasha Levin --- drivers/i2c/busses/i2c-sun6i-p2wi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c index 7c07ce116e384..540c33f4e3500 100644 --- a/drivers/i2c/busses/i2c-sun6i-p2wi.c +++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c @@ -202,6 +202,11 @@ static int p2wi_probe(struct platform_device *pdev) return -EINVAL; } + if (clk_freq == 0) { + dev_err(dev, "clock-frequency is set to 0 in DT\n"); + return -EINVAL; + } + if (of_get_child_count(np) > 1) { dev_err(dev, "P2WI only supports one slave device\n"); return -EINVAL; -- 2.42.0