Re: [PATCH 2/2] configs: Transpeed 8K618-T: Add Transpeed 8K618-T board support

[Andre Przywara <andre.przywara@arm.com>]

On Wed, 17 Jan 2024 11:37:56 -0500
Nick Alilovic <nickalilovic@gmail.com> wrote:

Hi Nick,

thanks for sending this!

> This is a Chinese TV box based on Allwinner H618 SoC.
> 
> The DRAM parameters were derived from the values found in a firmware update.
> 
> This patch will add transpeed-8k618-t_defconfig to the configs directory.

This last sentence is a bit out of place, the typical tone in a commit
message is to "direct the repository to make a change", so you use an
imperative. But it's more directed to the human reader of course, so
you don't need to replicate details like the exact filename, that are
spelt out three lines below here. So just a simple:

Add the defconfig file.

would suffice.

> 
> Signed-off-by: Nick Alilovic <nickalilovic@gmail.com>
> ---
>  configs/transpeed-8k618-t_defconfig | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 configs/transpeed-8k618-t_defconfig
> 
> diff --git a/configs/transpeed-8k618-t_defconfig b/configs/transpeed-8k618-t_defconfig
> new file mode 100644
> index 0000000000..7090577199
> --- /dev/null
> +++ b/configs/transpeed-8k618-t_defconfig
> @@ -0,0 +1,25 @@
> +CONFIG_ARM=y
> +CONFIG_ARCH_SUNXI=y
> +CONFIG_DEFAULT_DEVICE_TREE="sun50i-h618-transpeed-8k618-t"
> +CONFIG_SPL=y
> +CONFIG_DRAM_SUN50I_H616_DX_ODT=0x03030303
> +CONFIG_DRAM_SUN50I_H616_DX_DRI=0x0e0e0e0e
> +CONFIG_DRAM_SUN50I_H616_CA_DRI=0x1f12
> +CONFIG_DRAM_SUN50I_H616_TPR0=0xc0001002
> +CONFIG_DRAM_SUN50I_H616_TPR10=0x2f1107
> +CONFIG_DRAM_SUN50I_H616_TPR11=0xddddcccc
> +CONFIG_DRAM_SUN50I_H616_TPR12=0xeddc7665
> +CONFIG_MACH_SUN50I_H616=y
> +CONFIG_SUNXI_DRAM_H616_DDR3_1333=y
> +CONFIG_DRAM_CLK=648
> +CONFIG_R_I2C_ENABLE=y
> +CONFIG_SPL_I2C=y
> +CONFIG_SPL_SYS_I2C_LEGACY=y
> +CONFIG_SYS_I2C_MVTWSI=y
> +CONFIG_SYS_I2C_SLAVE=0x7f
> +CONFIG_SYS_I2C_SPEED=400000
> +CONFIG_SUPPORT_EMMC_BOOT=y

You correctly mention this, but miss the required MMC controller number:

CONFIG_MMC_SUNXI_SLOT_EXTRA=2

> +CONFIG_AXP313_POWER=y
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_OHCI_HCD=y
> +CONFIG_AXP_DCDC3_VOLT=1360

This line belongs a few lines up. There is some non-obvious order of
those lines, which you can obtain by running "make savedefconfig" after
"make transpeed-8k618-t_defconfig". This will create a "defconfig"
file, which contains the minimal defconfig, in the right order. This
will be done routinely on all files in the configs/ directory
eventually, but it's good measure to get this right from the beginning,
to reduce churn.

You are also missing:
# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
which is somewhat mandatory on all Allwinner boards.
I don't actually remember why exactly, but we have this for almost
every sunxi board.

Thanks,
Andre