From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5AAF31586D7 for ; Mon, 29 Jan 2024 16:59:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706547600; cv=none; b=H1FKiwtu/iaXUxYbns01g70AUvjuqanU3f5aDEN9ivR2KrLkCQgG8JMFDQwtC1cJeG6/QrOgYqbekrnGsM/3bLi7BYNlaVpLitT2DUVa1na45Gzr822rqCwK8M60b5cABwAQZlySJbZjnUzCW0KVNgxvfF7cCpqQOfNYbVJj7S4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706547600; c=relaxed/simple; bh=6AlW8GfU0yXdn2MsLvTWS4FUIIv27Mo017RHrFWdyIk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=i1XQfyl42CHfcOcUNlt2OrXjyJWRo3tvhfs7jW8g3kTxm8iaAkx9wyxgzm/jI7z48cgAESHZyhUfMSEhnXpO4Efz08NM+yVeDeoACNm5pw2JdXvyT2oS+FAIhfCvYbYRdirzgJvmJ2krz9Od8usnPArIvCf/ZrJYBQB19iVamok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AFF1CDA7; Mon, 29 Jan 2024 09:00:41 -0800 (PST) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9A3213F738; Mon, 29 Jan 2024 08:59:55 -0800 (PST) Date: Mon, 29 Jan 2024 16:59:52 +0000 From: Andre Przywara To: Chen-Yu Tsai Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Vinod Koul , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-sound@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/7] dt-bindings: dma: allwinner,sun50i-a64-dma: Add compatible for H616 Message-ID: <20240129165952.0dec633e@donnerap.manchester.arm.com> In-Reply-To: <20240127163247.384439-5-wens@kernel.org> References: <20240127163247.384439-1-wens@kernel.org> <20240127163247.384439-5-wens@kernel.org> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 28 Jan 2024 00:32:44 +0800 Chen-Yu Tsai wrote: Hi, > From: Chen-Yu Tsai > > The DMA controllers found on the H616 and H618 are the same as the one > found on the A100. The only difference is the DMA endpoint (DRQ) layout. > > Since the number of channels and endpoints are described with additional > generic properties, just add a new H616-specific compatible string and > fallback to the A100 one. > > Signed-off-by: Chen-Yu Tsai Looks good, A100 is the right fallback string. dt-binding_check passed for me. Reviewed-by: Andre Przywara Cheers, Andre > --- > Changes since v1: > - Switch to "contains" for if-properties statement > - Fall back to A100 instead of H6 > > .../bindings/dma/allwinner,sun50i-a64-dma.yaml | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml > index ec2d7a789ffe..0f2501f72cca 100644 > --- a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml > +++ b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml > @@ -28,6 +28,9 @@ properties: > - items: > - const: allwinner,sun8i-r40-dma > - const: allwinner,sun50i-a64-dma > + - items: > + - const: allwinner,sun50i-h616-dma > + - const: allwinner,sun50i-a100-dma > > reg: > maxItems: 1 > @@ -59,10 +62,11 @@ required: > if: > properties: > compatible: > - enum: > - - allwinner,sun20i-d1-dma > - - allwinner,sun50i-a100-dma > - - allwinner,sun50i-h6-dma > + contains: > + enum: > + - allwinner,sun20i-d1-dma > + - allwinner,sun50i-a100-dma > + - allwinner,sun50i-h6-dma > > then: > properties: