From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BF30580C for ; Thu, 25 Apr 2024 00:36:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714005379; cv=none; b=iCKFR/RW7ZMjTKhUyXv8NAiG/UzOpWwsYHzc5WxieJAO8ZuQNjk+soVDfo+Xv/yLXefqkqHTr3UM/PEInhrY//FQTiFczjKtWRpRXI6+pGdQvr03iin/A0VeYQijIBsz7nOcz7IIJ0UxVmIFJXgxPQLYUKVEEmSQAQ0CzHQ3HA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714005379; c=relaxed/simple; bh=Pk/sHrPl6C3mqNZupy8ctRKT5NWa/ZiuI+NX9d52oUY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZKTwP9Yr8Hv7fUs8BvX2kOADJgvFIJ4wb/pGgin2t4aO3MItZMQAXhn6E8zUkBlmkbw631FGdUcbV7y6A4bMWLIIXcn8+nav2VU9lq4tzdovMHUDx/LfH7Ky7G39AksCcJImyuDvAa91rp+3OK766scYM703Mdq7sCahJEK4GIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B4401007; Wed, 24 Apr 2024 17:36:45 -0700 (PDT) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB4E13F7BD; Wed, 24 Apr 2024 17:36:15 -0700 (PDT) Date: Thu, 25 Apr 2024 01:35:59 +0100 From: Andre Przywara To: Ryan Walklin Cc: Chen-Yu Tsai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jernej Skrabec , Samuel Holland , Chris Morgan , devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v3 4/4] arm64: dts: allwinner: h700: Add RG35XX-H DTS Message-ID: <20240425013559.5b5d1fe4@minigeek.lan> In-Reply-To: <20240424110947.9057-5-ryan@testtoast.com> References: <20240424110947.9057-1-ryan@testtoast.com> <20240424110947.9057-5-ryan@testtoast.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 24 Apr 2024 23:09:47 +1200 Ryan Walklin wrote: > The RG35XX-H adds thumbsticks, a stereo speaker, and a second USB port to the RG35XX-Plus, and has a horizontal form factor. > > Enabled in this DTS: > - Thumbsticks > - Second USB port > > Signed-off-by: Ryan Walklin > --- > Changelog v1..v2: > - Update copyright > - Spaces -> Tabs > - Add GP ADC joystick axes and mux [1] > - Add EHCI/OHCI1 for second USB port and add vbus supply > > Changelog v2..v3: > - Add DTB to Makefile > - Remove USB vbus supply > - Remove GPADC joysticks until required patches land [1] > - Move thumbsticks into existing gpio gamepad node > - Move changelog and links below fold-line > > [1]: https://lore.kernel.org/linux-sunxi/20240417170423.20640-1-macroalpha82@gmail.com/T/#t > > --- > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../sun50i-h700-anbernic-rg35xx-h.dts | 46 +++++++++++++++++++ > 2 files changed, 47 insertions(+) > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-h.dts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > index 4217328b1889..c2c871d8b71e 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -49,3 +49,4 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-orangepi-zero3.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-transpeed-8k618-t.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-2024.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-plus.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-h.dtb > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-h.dts b/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-h.dts > new file mode 100644 > index 000000000000..3f4435ff9b71 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-h.dts > @@ -0,0 +1,46 @@ > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +/* > + * Copyright (C) 2024 Ryan Walklin . > + * Copyright (C) 2024 Chris Morgan . > + */ > + > +#include "sun50i-h700-anbernic-rg35xx-plus.dts" > + > +/ { > + model = "Anbernic RG35XX H"; > + compatible = "anbernic,rg35xx-h", "allwinner,sun50i-h700"; > +}; > + > +&gpio_keys_gamepad { > + > + button-thumbl { > + label = "GPIO Thumb Left"; > + gpios = <&pio 4 8 GPIO_ACTIVE_LOW>; /* PE8 */ > + linux,input-type = ; > + linux,code = ; > + }; > + > + button-thumbr { > + label = "GPIO Thumb Right"; > + gpios = <&pio 4 9 GPIO_ACTIVE_LOW>; /* PE9 */ > + linux,input-type = ; > + linux,code = ; > + }; > +}; > + > +&ehci1 { > + status = "okay"; > +}; > + > +&ohci1 { > + status = "okay"; > +}; > + > +&usbotg { > + dr_mode = "peripheral"; > + status = "okay"; > +}; > + > +&usbphy { > + status = "okay"; > +}; Those two nodes look redundant, since they exist already in the base .dts. I guess &usbphy needs to be adjusted later, but &usbotg is likely to stay the same? Anyway, it doesn't really hurt, so: Reviewed-by: Andre Przywara Cheers, Andre