From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F29793FE2A for ; Fri, 24 May 2024 18:54:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716576890; cv=none; b=XYUop52dB1K40U/3jZqNbOoua4Uk/WvfmLC7xmp4JUgy9XJ45DlGvjjMmg/OK3AbfmoqmLKx1uD248BgUtMnV0bOg1UhHp9Nk0ll8h+1dujNFSCt8WtY1E9nSDyG2jTGJYUqsa7rOXI+7pNZsNv6Xpm0D8x8Ok8R1idbQdsCq0I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716576890; c=relaxed/simple; bh=qn6Vkvzj5JGs44Cc6xvsUt9I7gZyNx3518aH165iGSw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=guMBHjOBmdPncW0P27aVEnRCIp0lZchCZHbccNKi89cPAt3DYfT7MvREoNMRDpjvR6LtXnUyJxBWVIYX6FK8arSAPlzVd8pSxnQ91pBKWkiADI2hSFWgff6EFXMrhsn2CzT2vjERGCrEINA2jG5evoghupVmklV6Dxdr46R/mJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3A140339; Fri, 24 May 2024 11:55:11 -0700 (PDT) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A395F3F762; Fri, 24 May 2024 11:54:45 -0700 (PDT) Date: Fri, 24 May 2024 19:52:36 +0100 From: Andre Przywara To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH] arm64: dts: allwinner: convert NanoPi R1S H5 NVMEM content to layout syntax Message-ID: <20240524195236.289b4e8f@minigeek.lan> In-Reply-To: <20240524125617.27714-1-zajec5@gmail.com> References: <20240524125617.27714-1-zajec5@gmail.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 24 May 2024 14:56:17 +0200 Rafa=C5=82 Mi=C5=82ecki wrote: Hi Rafa=C5=82, > From: Rafa=C5=82 Mi=C5=82ecki >=20 > Use cleaner (and non-deprecated) bindings syntax. See commit > bd912c991d2e ("dt-bindings: nvmem: layouts: add fixed-layout") for > details. Is there anything that this commit fixes, or is it just "nicer"? If I see this correctly, then this commit would break with older kernels, or more precisely anything that doesn't support the "fixed-layout" compatible string, right? For sunxi we try to keep the DTs compatible both ways, so that the latest DT (as imported in U-Boot, for instance), can run with both older stable and the newest kernels. Cheers, Andre > Signed-off-by: Rafa=C5=82 Mi=C5=82ecki > --- > .../boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) >=20 > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts b/= arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts > index 3a7ee44708a2..36e46e40b8f8 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts > @@ -146,11 +146,15 @@ eeprom@51 { > reg =3D <0x51>; > pagesize =3D <16>; > read-only; > - #address-cells =3D <1>; > - #size-cells =3D <1>; > =20 > - eth_mac1: mac-address@fa { > - reg =3D <0xfa 0x06>; > + nvmem-layout { > + compatible =3D "fixed-layout"; > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + > + eth_mac1: mac-address@fa { > + reg =3D <0xfa 0x06>; > + }; > }; > }; > };