Re: [PATCH 1/2] dt-bindings: arm: sunxi: Add Anbernic RG35XXSP

Andre Przywara
2024-06-06T10:26:19Z

On Wed, 5 Jun 2024 13:53:38 -0500
Chris Morgan <macroalpha82@gmail.com> wrote:

Hi,

> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add the Anbernic RG35XXSP variant device and consolidate the Anbernic
> H700 devices.
>
> The Anbernic RG35XXSP is almost identical to the RG35XX-Plus, but in a
> clamshell form-factor.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
> .../devicetree/bindings/arm/sunxi.yaml | 24 +++++++------------
> 1 file changed, 9 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index c2a158b75e49..1ae77e5edf9a 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -51,25 +51,19 @@ properties:
> - const: allwinner,parrot
> - const: allwinner,sun8i-a33
>
> - - description: Anbernic RG-Nano
> - items:
> - - const: anbernic,rg-nano
> - - const: allwinner,sun8i-v3s
> -
> - - description: Anbernic RG35XX (2024)
> - items:
> - - const: anbernic,rg35xx-2024
> - - const: allwinner,sun50i-h700
> -
> - - description: Anbernic RG35XX Plus
> + - description: Anbernic H700 Handheld Gaming Console

So that's certainly an interesting optimisation, but so far we were using
one entry per device, it seems.
I am not entirely sure what the purpose of this file is, exactly: just to
document the compatible names, to reserve them and avoid clashes in the
future? Or also to put some official names to each device? That seems to
somewhat overlap with the root node's model property in the respective
device .dts, though.

It would be good to clarify this, and establish how to group those devices.
I mean technically we could for instance put *all* H6 devices into one
entry, using the same scheme as below.
Not sure that's desired, though.

Cheers,
Andre

> items:
> - - const: anbernic,rg35xx-plus
> + - enum:
> + - anbernic,rg35xx-2024
> + - anbernic,rg35xx-h
> + - anbernic,rg35xx-plus
> + - anbernic,rg35xx-sp
> - const: allwinner,sun50i-h700
>
> - - description: Anbernic RG35XX H
> + - description: Anbernic RG-Nano
> items:
> - - const: anbernic,rg35xx-h
> - - const: allwinner,sun50i-h700
> + - const: anbernic,rg-nano
> + - const: allwinner,sun8i-v3s
>
> - description: Amarula A64 Relic