From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 160C6A29 for ; Wed, 19 Jun 2024 00:01:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718755318; cv=none; b=XXa8giwV29YRCHOmix1v0f4cMzUoKigNZGYFJFo30UvAmASdp1lpc7lOCEKPOi+Wie8Ka+DZZF+QzR1vv2pGb7a8+jOw256TixI+ApDWGQvOxBlzSCiUVAjUo9oQm6z+GblI1cmEZ2mrczuupQV+e24N7tZ2kdTeYuZn3XebQBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718755318; c=relaxed/simple; bh=jMeof6mQ4m9OsdFZSVhbZbBYZBSBZlEpy+R0gWz7uwo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VAU+eLkcGf/wjgVq1fwfrVk/mRqXKZO1dMYXTDYT8d1x0uYPbY9nN6zscUaLFPZ1xSfFbEhlFha1g4Fv4DrxxzxmS4o5MP1hJYBLCUko9F0Ul7y1eGFP783qHqOItxtRhsadpylghMiNjH4hryUZNTaiEyi8AEF9iBa1ZJSyXHc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 099A9DA7; Tue, 18 Jun 2024 17:02:20 -0700 (PDT) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 28F753F64C; Tue, 18 Jun 2024 17:01:53 -0700 (PDT) Date: Wed, 19 Jun 2024 01:00:21 +0100 From: Andre Przywara To: Ryan Walklin Cc: Yangtao Li , "Rafael J . Wysocki" , Viresh Kumar , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Chris Morgan , Sudeep Holla , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Stephen Boyd , Rob Herring Subject: Re: [PATCH 1/3] cpufreq: sun50i: add Allwinner H700 speed bin Message-ID: <20240619010021.5962e459@minigeek.lan> In-Reply-To: <20240607092140.33112-2-ryan@testtoast.com> References: <20240607092140.33112-1-ryan@testtoast.com> <20240607092140.33112-2-ryan@testtoast.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 7 Jun 2024 21:20:33 +1200 Ryan Walklin wrote: > Support for the Allwinner H618, H618 and H700 was added to the sun50i > cpufreq-nvmem driver recently [1] however at the time some operating > points supported by the H700 (1.008, 1.032 and 1.512 GHz) and in use by > vendor BSPs were found to be unstable during testing, so the H700 speed > bin and the 1.032 GHz OPP were not included in the mainline driver. > > Retesting with kernel 6.10rc2 (which carries additional fixes for the > driver) now shows stable operation with these points. > > Add the H700 speed bin to the driver. > > Signed-off-by: Ryan Walklin Yes, 0x6c00 is the value for the H700 SoCs in the devices we have seen: Reviewed-by: Andre Przywara Thanks, Andre > -- > [1] https://lore.kernel.org/linux-sunxi/20240418154408.1740047-1-andre.przywara@arm.com > --- > drivers/cpufreq/sun50i-cpufreq-nvmem.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/cpufreq/sun50i-cpufreq-nvmem.c b/drivers/cpufreq/sun50i-cpufreq-nvmem.c > index 0b882765cd66f..969f22aadd950 100644 > --- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c > +++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c > @@ -91,6 +91,9 @@ static u32 sun50i_h616_efuse_xlate(u32 speedbin) > case 0x5d00: > value = 0; > break; > + case 0x6c00: > + value = 5; > + break; > default: > pr_warn("sun50i-cpufreq-nvmem: unknown speed bin 0x%x, using default bin 0\n", > speedbin & 0xffff);