Re: [PATCH 14/23] drm: sun4i: de2/de3: refactor mixer initialisation

Ryan Walklin
2024-06-25T01:23:47Z

Hi Andre,

On Tue, 25 Jun 2024, at 12:28 PM, Andre Przywara wrote:

Thanks for the review!

>> regmap_write(mixer->engine.regs, SUN50I_MIXER_CDC1_EN, 0);
>> - } else {
>> +
>
> That seems to add an extra line, which shouldn't be here.

This was intentional to add some whitespace between the block of register writes and the next if/then block, but happy to remove delete if that is the style preference.

>
> Verified that the rest is indeed just a code move, from below into a
> separate function. So with the two minor bits above fixed:
>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
>

Thanks again!

Ryan