From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32DF618133F for ; Tue, 25 Jun 2024 21:09:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719349793; cv=none; b=B34efXTRT3hrpon5MAw5rsPVp0DJdWH3hOQMA+n0gpaFLMooWHnY6w5r73Ksol2dglcc41GV6JxO8eNC9o3E0dgcAUWpa91h8NN1ZFKkzZQd2/o62nPYAD4IabVwpn5TopQSNk5/XJLnsY6urc/5WOU/4STRHiU9URG4oy2l7EI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719349793; c=relaxed/simple; bh=1PYksQ3E9z4msNPu5htpDLVmL9zgWuVlY34orOJ78PQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BROxJDGnFvhe+NI95K5CCe64m6ihozgiZ6gXS2MuCJv6N0yZQKCBe3zJ6g2rGHIIPpRVRtF+72uhYd/EaJCxSAehhoXcp5PRx7Jakv58DgTym2gpIQBX98yDjI+etN4PvBoiMwKUTwElQBTo38Oef3zYMKUn0VOIL5h8qB9kGPc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=hCzpkt/c; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="hCzpkt/c" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3EA4D512; Tue, 25 Jun 2024 23:09:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1719349767; bh=1PYksQ3E9z4msNPu5htpDLVmL9zgWuVlY34orOJ78PQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hCzpkt/cYwQMpgcV6XmKyCmFhOSErR0m+ex+3HrH0zEyOGKTDhAojO/tdd809eygh ieJ5tVMvBNYrSJg4qzshxaogOZzFtai8AeFbRLPzv9/SBSPQm90+3sqN//UnNXnbm+ ikKm234BCwFme1fYKGYs/zCsAqdyk5VKQAJrJ0vs= Date: Wed, 26 Jun 2024 00:09:28 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, Eugen Hristev , Maxime Ripard , Chen-Yu Tsai , Kieran Bingham , Tomi Valkeinen , Jacopo Mondi , Hans Verkuil Subject: Re: [PATCH 2/8] media: sun4i_csi: Implement link validate for sun4i_csi subdev Message-ID: <20240625210928.GA29726@pendragon.ideasonboard.com> References: <20240619012356.22685-1-laurent.pinchart+renesas@ideasonboard.com> <20240619012356.22685-3-laurent.pinchart+renesas@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Sat, Jun 22, 2024 at 04:44:15PM +0000, Sakari Ailus wrote: > On Wed, Jun 19, 2024 at 04:23:50AM +0300, Laurent Pinchart wrote: > > The sun4i_csi driver doesn't implement link validation for the subdev it > > registers, leaving the link between the subdev and its source > > unvalidated. Fix it, using the v4l2_subdev_link_validate() helper. > > > > Signed-off-by: Laurent Pinchart > > This looks like a bugfix. Shouldn't this be backported? I'll add Fixes: 577bbf23b758 ("media: sunxi: Add A10 CSI driver") -- Regards, Laurent Pinchart