From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-sunxi@lists.linux.dev,
Eugen Hristev <eugen.hristev@collabora.com>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: Re: [PATCH 2/8] media: sun4i_csi: Implement link validate for sun4i_csi subdev
Date: Wed, 26 Jun 2024 08:50:25 +0300 [thread overview]
Message-ID: <20240626055025.GA8704@pendragon.ideasonboard.com> (raw)
In-Reply-To: <Zns7YKMVa0tvOI24@valkosipuli.retiisi.eu>
On Tue, Jun 25, 2024 at 09:49:20PM +0000, Sakari Ailus wrote:
> On Wed, Jun 26, 2024 at 12:09:28AM +0300, Laurent Pinchart wrote:
> > On Sat, Jun 22, 2024 at 04:44:15PM +0000, Sakari Ailus wrote:
> > > On Wed, Jun 19, 2024 at 04:23:50AM +0300, Laurent Pinchart wrote:
> > > > The sun4i_csi driver doesn't implement link validation for the subdev it
> > > > registers, leaving the link between the subdev and its source
> > > > unvalidated. Fix it, using the v4l2_subdev_link_validate() helper.
> > > >
> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > >
> > > This looks like a bugfix. Shouldn't this be backported?
> >
> > I'll add
> >
> > Fixes: 577bbf23b758 ("media: sunxi: Add A10 CSI driver")
>
> Please also:
>
> Cc: stable@vger.kernel.org
Done.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2024-06-26 5:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 1:23 [PATCH 0/8] media: v4l2: Improve media link validation Laurent Pinchart
2024-06-19 1:23 ` [PATCH 1/8] media: microchip-isc: Drop v4l2_subdev_link_validate() for video devices Laurent Pinchart
2024-06-19 1:23 ` [PATCH 2/8] media: sun4i_csi: Implement link validate for sun4i_csi subdev Laurent Pinchart
2024-06-22 15:03 ` Chen-Yu Tsai
2024-06-22 16:44 ` Sakari Ailus
2024-06-25 21:09 ` Laurent Pinchart
2024-06-25 21:49 ` Sakari Ailus
2024-06-26 5:50 ` Laurent Pinchart [this message]
2024-06-19 1:23 ` [PATCH 3/8] media: sun4i_csi: Don't use v4l2_subdev_link_validate() for video device Laurent Pinchart
2024-06-22 15:04 ` Chen-Yu Tsai
2024-06-19 1:23 ` [PATCH 4/8] media: v4l2-subdev: Refactor warnings in v4l2_subdev_link_validate() Laurent Pinchart
2024-06-22 16:47 ` Sakari Ailus
2024-06-25 14:02 ` Laurent Pinchart
2024-06-25 15:46 ` Sakari Ailus
2024-06-25 15:54 ` Laurent Pinchart
2024-06-19 1:23 ` [PATCH 5/8] media: v4l2-subdev: Support hybrid links " Laurent Pinchart
2024-06-19 1:23 ` [PATCH 6/8] media: renesas: vsp1: Print debug message to diagnose validation failure Laurent Pinchart
2024-06-19 1:23 ` [PATCH 7/8] media: renesas: vsp1: Implement .link_validate() for video devices Laurent Pinchart
2024-06-19 1:23 ` [PATCH 8/8] [DNI] media: renesas: vsp1: Validate all links through .link_validate() Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626055025.GA8704@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=eugen.hristev@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox