From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 57E52A95B for ; Sat, 6 Jul 2024 22:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720306363; cv=none; b=ly5Ws/UPprOUt/iKFWuyqfXt2FFdHhRQlGybPZQW4Y0gAYuxe44lLlfEbYZ1a/T/yFVKgzs/V/Qlgosx3+LLAEbgL4MII3JDg3Mt3Bi17mgEBQ5zQ/uubS5bvULbdGeTfpSBjxTjy0b07fo5RQHFxAWrlM5Lueiy+Cfn/m4SQgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720306363; c=relaxed/simple; bh=ZK90u5RYphGiY8mFBPfe6XQyxZbvTFXAPWCE9dNGt4k=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ABrpPuoy4ELRqYxR8UWPCqfNIcCVcHqz5gFX/d6NEtZMOKv3ICzCBFlJV0IWOKZ+vvHb9pEtunH3FJzPWPW3GEYIZFwt3PpcjLFTN7v9/4JMfsh1XaxWFju5OfsGE9wUqpxSEu9l07G9wcUwJKZFxOrUDgJkonAEjbi7Z7IGkys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A667BDA7; Sat, 6 Jul 2024 15:53:05 -0700 (PDT) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 82D2F3F762; Sat, 6 Jul 2024 15:52:39 -0700 (PDT) Date: Sat, 6 Jul 2024 23:50:41 +0100 From: Andre Przywara To: Javier Carrasco Cc: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: sunxi: sram: Constify struct regmap_config Message-ID: <20240706235041.1c5181b8@minigeek.lan> In-Reply-To: <20240705-sunxi-sram-const-regmap_config-v1-1-1b997cd65d0f@gmail.com> References: <20240705-sunxi-sram-const-regmap_config-v1-1-1b997cd65d0f@gmail.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 05 Jul 2024 12:52:27 +0200 Javier Carrasco wrote: > `sunxi_sram_regmap_config` is not modified and can be declared as const > to move its data to a read-only section. > > Signed-off-by: Javier Carrasco Reviewed-by: Andre Przywara Cheers, Andre > --- > drivers/soc/sunxi/sunxi_sram.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c > index 71cc377b5e24..2781a091a6a6 100644 > --- a/drivers/soc/sunxi/sunxi_sram.c > +++ b/drivers/soc/sunxi/sunxi_sram.c > @@ -344,7 +344,7 @@ static void sunxi_sram_unlock(void *_lock) > spin_unlock(lock); > } > > -static struct regmap_config sunxi_sram_regmap_config = { > +static const struct regmap_config sunxi_sram_regmap_config = { > .reg_bits = 32, > .val_bits = 32, > .reg_stride = 4, > > --- > base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233 > change-id: 20240705-sunxi-sram-const-regmap_config-d05d1bb0583c > > Best regards,