From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E69E818786C for ; Thu, 5 Sep 2024 04:18:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725509882; cv=none; b=pAqqcKFSVfmc1yyFY1kwZkjbaje9q+aLIyVuA5YYk2fcN6C1V1jov7HqFjzOCa7MGS5145iZKYkD4CvYxRAyo79NvUyPC2XLRooLP4XQjV+BCg0AE4T8y2EmWJIv09DW8gX0NTj9bly8Lb7o06Fwr8O8QwdTn+/5/bcgUp2bTF8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725509882; c=relaxed/simple; bh=i9osRIZI2r8pLinAa1PuSzq4Uf0jxagbDh5hgtSxDZo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZWYavPbpawSBmF8oATxjkGy8Tj99pujbJCwpOQpy9jFK0eAVg7sJPTcRjrO/vl218Utt3PzbhAnT8ez0hsN3Jh0VinHBwAsbs0Cr7pwWr9w73Xqf9jdEKPX6mM3KukCvx5ghc70e0Kwa65J//GGf5IqAvt2YtFU750VtOZcKYyw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gHNbpsQS; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gHNbpsQS" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3df16ece2c2so193051b6e.2 for ; Wed, 04 Sep 2024 21:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725509880; x=1726114680; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wySGI9scoJi4TljRD+Hpmp4oNTGGODlyYEe5tlANPZw=; b=gHNbpsQS92lYLUHe6G0fbmA8lts8NUp0t1Tfwi25LtGnrfe3KZTFozDJdN+kQhYu4M BiPVovP1Z0DQcZFlsCaK9v6OdEZYDnc7DUK6q/otdQv0OcICd9MLGr20NqoFEAvxSYGb VCrv3v7WDr6YcTTkNokY1WLif5nUeaE/w8qA5bh0VYGFZxNonZLQuhISJm7h4rZx66Yt Yylz7CgbOK/Oq/mUtsus/LaXnR+8MnvkZ+Whix7DM8ezgKSmKRy5pJazVojlB+ZwEjyv K/p7aAym3nURQ9D4ZmPN1AMKxp8Y2aYOthyYnqMtWezhrP4oaVB4MZbb/szMvlpIYi9J JY9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725509880; x=1726114680; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wySGI9scoJi4TljRD+Hpmp4oNTGGODlyYEe5tlANPZw=; b=ipX8Iafn68akVYANlClC+lb+3boFWOBoBo458ydbl/YaM61Ie8LAntocfVTNe5ctQK UajDtc5xHlkHVaAObiRV2LWfTLYO6k30wnhNpjs9DVnobQTg5OhiOhJ25NxFOppqaypc 6u9mQ13CYA3N2zOPCUdfWUuuYOXU/3g5lmj/C9B+iFX4C8KhE7yiZUtx/KJ5sEbMYbiD YbF4A2tpnLX7e+tLNjvGMMtOyKgqe1/mL74KoW/sKd7A+ic3SGJtTla+JkgH2m2+ECm3 Hc8U5z+9PKFZZI2eJnnvHYr7c5ku/HcZ2HS6kKb2Z34pCsqxamz9r2B7jMlKnCMf+sc7 z2Pw== X-Forwarded-Encrypted: i=1; AJvYcCXUFiLfnRIdYwr1WidewUh668GhWrIBW8/hs/0zt2x4u+jkZPADV29yQLvEO89CJbP8etCVUPT1sNgxxw==@lists.linux.dev X-Gm-Message-State: AOJu0Yx3ZadswNnTcrUXIqmI1LvNRTDrlwCbES56NPGNcSZWTHYAaIdu 7JfrcoIXw497wSMusOkB/StHVVO9iO4/g+wSEf1695NqBhPxhLoL X-Google-Smtp-Source: AGHT+IEQOPemQhEEQd4JD206/3mLVfaYjNo57sTDwNHwWOJ0RwSvTidH6chDqJAiBF7WrpAvcYyjrQ== X-Received: by 2002:a05:6808:11c5:b0:3dc:39e9:e04 with SMTP id 5614622812f47-3df22106d0fmr17555384b6e.20.1725509879905; Wed, 04 Sep 2024 21:17:59 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2620:15c:9d:2:13bd:b4e:4c0f:4c37]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7d4fbd8d52esm2450216a12.32.2024.09.04.21.17.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 21:17:59 -0700 (PDT) From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: =?UTF-8?q?Pali=20Roh=C3=A1r?= , Helge Deller , "K. Y. Srinivasan" , Wei Liu , Dexuan Cui , Samuel Holland , Lyude Paul , Michal Simek , Hans de Goede , linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH 11/24] Input: hyperv-keyboard - use guard notation when acquiring spinlock Date: Wed, 4 Sep 2024 21:17:16 -0700 Message-ID: <20240905041732.2034348-12-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.46.0.469.g59c65b2a67-goog In-Reply-To: <20240905041732.2034348-1-dmitry.torokhov@gmail.com> References: <20240905041732.2034348-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Using guard notation makes the code more compact and error handling more robust by ensuring that locks are released in all code paths when control leaves critical section. Signed-off-by: Dmitry Torokhov --- drivers/input/serio/hyperv-keyboard.c | 38 +++++++++++++-------------- 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/drivers/input/serio/hyperv-keyboard.c b/drivers/input/serio/hyperv-keyboard.c index 31d9dacd2fd1..0ee7505427ac 100644 --- a/drivers/input/serio/hyperv-keyboard.c +++ b/drivers/input/serio/hyperv-keyboard.c @@ -102,7 +102,6 @@ static void hv_kbd_on_receive(struct hv_device *hv_dev, { struct hv_kbd_dev *kbd_dev = hv_get_drvdata(hv_dev); struct synth_kbd_keystroke *ks_msg; - unsigned long flags; u32 msg_type = __le32_to_cpu(msg->header.type); u32 info; u16 scan_code; @@ -147,21 +146,22 @@ static void hv_kbd_on_receive(struct hv_device *hv_dev, /* * Inject the information through the serio interrupt. */ - spin_lock_irqsave(&kbd_dev->lock, flags); - if (kbd_dev->started) { - if (info & IS_E0) - serio_interrupt(kbd_dev->hv_serio, - XTKBD_EMUL0, 0); - if (info & IS_E1) - serio_interrupt(kbd_dev->hv_serio, - XTKBD_EMUL1, 0); - scan_code = __le16_to_cpu(ks_msg->make_code); - if (info & IS_BREAK) - scan_code |= XTKBD_RELEASE; + scoped_guard(spinlock_irqsave, &kbd_dev->lock) { + if (kbd_dev->started) { + if (info & IS_E0) + serio_interrupt(kbd_dev->hv_serio, + XTKBD_EMUL0, 0); + if (info & IS_E1) + serio_interrupt(kbd_dev->hv_serio, + XTKBD_EMUL1, 0); + scan_code = __le16_to_cpu(ks_msg->make_code); + if (info & IS_BREAK) + scan_code |= XTKBD_RELEASE; - serio_interrupt(kbd_dev->hv_serio, scan_code, 0); + serio_interrupt(kbd_dev->hv_serio, + scan_code, 0); + } } - spin_unlock_irqrestore(&kbd_dev->lock, flags); /* * Only trigger a wakeup on key down, otherwise @@ -292,11 +292,10 @@ static int hv_kbd_connect_to_vsp(struct hv_device *hv_dev) static int hv_kbd_start(struct serio *serio) { struct hv_kbd_dev *kbd_dev = serio->port_data; - unsigned long flags; - spin_lock_irqsave(&kbd_dev->lock, flags); + guard(spinlock_irqsave)(&kbd_dev->lock); + kbd_dev->started = true; - spin_unlock_irqrestore(&kbd_dev->lock, flags); return 0; } @@ -304,11 +303,10 @@ static int hv_kbd_start(struct serio *serio) static void hv_kbd_stop(struct serio *serio) { struct hv_kbd_dev *kbd_dev = serio->port_data; - unsigned long flags; - spin_lock_irqsave(&kbd_dev->lock, flags); + guard(spinlock_irqsave)(&kbd_dev->lock); + kbd_dev->started = false; - spin_unlock_irqrestore(&kbd_dev->lock, flags); } static int hv_kbd_probe(struct hv_device *hv_dev, -- 2.46.0.469.g59c65b2a67-goog