From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 159B31482E9 for ; Thu, 5 Sep 2024 22:59:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725577175; cv=none; b=RzuxLkL/y3y08jlLmFIued11feji+6oO34+FgfQdNkVHHwUzo5A8WXCC7AoMykSNss9ntxMSYEmMY86/In0D/jETOBg5vU6n+TSbYnzEWSYBSNG86e6oM1f0OU+lkReV+VnuGjGoeF+yf4uBgsTwWYAXq7kE9HUbMd+SmtJta7o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725577175; c=relaxed/simple; bh=IVj1CpJpWrMZkbLOmAh8pJn8rBEU5hLsJM2ZdHrtno8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pgb+ye1txwqmjLS1rQYzRkd0x+3nl3gwMGYmAAwnB9jFUdCpee7yJsMJx+2LiTj3t7Lnsksp2oRXQrQwCAwb+Z6POFjykKXmcJazthX7hmMj3ADCBp67l0ol4sF0XK+58r+99OlkxI0wwp3C/NgiONGG9qblYdEJrvIKUUGhGs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 88308DA7; Thu, 5 Sep 2024 15:59:57 -0700 (PDT) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 393F13F73B; Thu, 5 Sep 2024 15:59:29 -0700 (PDT) Date: Thu, 5 Sep 2024 23:58:47 +0100 From: Andre Przywara To: =?UTF-8?B?S3J5xaF0b2YgxIxlcm7DvQ==?= Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] NanoPi NEO Plus2: Fix regulators and assign them Message-ID: <20240905235847.3b4b1374@minigeek.lan> In-Reply-To: <20240905-nanopi-neo-plus2-regfix-v3-0-1895dff59598@gmail.com> References: <20240905-nanopi-neo-plus2-regfix-v3-0-1895dff59598@gmail.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 05 Sep 2024 19:37:09 +0200 Kry=C5=A1tof =C4=8Cern=C3=BD wrote: Hi Kry=C5=A1tof, thanks for the follow-up! > Just minor changes based on feedback. >=20 > Signed-off-by: Kry=C5=A1tof =C4=8Cern=C3=BD There is no need for a Signed-off-by: in the cover letter. But you are supposed to add any tags, like my "Reviewed-by", to a new revision. I guess unfortunately you missed the v6.12 merge window by an hour or so, but in any case I hope Chen-Yu can copy in the tags when applying. > --- > Changes in v3: > - Renamed patches - added prefix. > - Remove the patch that added regulator to emmc. > - Link to v2: https://lore.kernel.org/r/20240827-nanopi-neo-plus2-regfix-= v2-0-497684ec82c7@gmail.com Thanks for the changelog, that's helpful. Ideally you would stack this up with the changes from previous revisions, so listing the changes from v1 .. v2 here as well. Cheers, Andre >=20 > --- > Kry=C5=A1tof =C4=8Cern=C3=BD (2): > arm64: dts: allwinner: H5: NanoPi Neo Plus2: Fix regulators > arm64: dts: allwinner: H5: NanoPi NEO Plus2: Use regulators for pio >=20 > .../dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 37 ++++++++++++++++= ++++++ > 1 file changed, 37 insertions(+) > --- > base-commit: 6f923748057a4f6aa187e0d5b22990d633a48d12 > change-id: 20240827-nanopi-neo-plus2-regfix-b60116ce12ca >=20 > Best regards,