From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>, "Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Maíra Canal" <mcanal@igalia.com>,
"Raspberry Pi Kernel Maintenance" <kernel-list@raspberrypi.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: [PATCH v2 0/6] drm/display: hdmi: add drm_hdmi_connector_mode_valid()
Date: Fri, 01 Nov 2024 02:25:03 +0200 [thread overview]
Message-ID: <20241101-hdmi-mode-valid-v2-0-a6478fd20fa6@linaro.org> (raw)
Several HDMI drivers have common code pice in the .mode_valid function
that validates RGB / 8bpc rate using the TMDS char rate callbacks.
Move this code piece to the common helper and remove the need to perform
this check manually. In case of DRM_BRIDGE_OP_HDMI bridges, they can
skip the check in favour of performing it in drm_bridge_connector.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
Changes in v2:
- Switched drm_hdmi_connector_mode_valid() to use common helper
(ex-hdmi_clock_valid()) (Maxime)
- Added simple unit tests for drm_hdmi_connector_mode_valid().
- Link to v1: https://lore.kernel.org/r/20241018-hdmi-mode-valid-v1-0-6e49ae4801f7@linaro.org
---
Dmitry Baryshkov (6):
drm/display: hdmi: add generic mode_valid helper
drm/sun4i: use drm_hdmi_connector_mode_valid()
drm/vc4: use drm_hdmi_connector_mode_valid()
drm/display: bridge_connector: use drm_bridge_connector_mode_valid()
drm/bridge: lontium-lt9611: drop TMDS char rate check in mode_valid
drm/bridge: dw-hdmi-qp: replace mode_valid with tmds_char_rate
drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +-
drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 12 +-
drivers/gpu/drm/display/drm_bridge_connector.c | 16 +-
drivers/gpu/drm/display/drm_hdmi_helper.c | 45 ++++++
drivers/gpu/drm/display/drm_hdmi_helper_internal.h | 11 ++
drivers/gpu/drm/display/drm_hdmi_state_helper.c | 26 +---
drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 12 +-
drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 168 ++++++++++++++++++++-
drivers/gpu/drm/vc4/vc4_hdmi.c | 4 +-
include/drm/display/drm_hdmi_helper.h | 4 +
10 files changed, 252 insertions(+), 50 deletions(-)
---
base-commit: 623b1e4d2eace0958996995f9f88cb659a6f69dd
change-id: 20241018-hdmi-mode-valid-aaec4428501c
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
next reply other threads:[~2024-11-01 0:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 0:25 Dmitry Baryshkov [this message]
2024-11-01 0:25 ` [PATCH v2 1/6] drm/display: hdmi: add generic mode_valid helper Dmitry Baryshkov
2024-11-08 14:17 ` Maxime Ripard
2024-11-09 7:13 ` Dmitry Baryshkov
2024-11-01 0:25 ` [PATCH v2 2/6] drm/sun4i: use drm_hdmi_connector_mode_valid() Dmitry Baryshkov
2024-11-08 14:20 ` Maxime Ripard
2024-11-09 7:17 ` Dmitry Baryshkov
2024-11-01 0:25 ` [PATCH v2 3/6] drm/vc4: " Dmitry Baryshkov
2024-11-04 16:00 ` Dave Stevenson
2024-11-01 0:25 ` [PATCH v2 4/6] drm/display: bridge_connector: use drm_bridge_connector_mode_valid() Dmitry Baryshkov
2024-11-08 14:25 ` Maxime Ripard
2024-11-01 0:25 ` [PATCH v2 5/6] drm/bridge: lontium-lt9611: drop TMDS char rate check in mode_valid Dmitry Baryshkov
2024-11-08 14:25 ` Maxime Ripard
2024-11-01 0:25 ` [PATCH v2 6/6] drm/bridge: dw-hdmi-qp: replace mode_valid with tmds_char_rate Dmitry Baryshkov
2024-11-08 14:27 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101-hdmi-mode-valid-v2-0-a6478fd20fa6@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel-list@raspberrypi.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcanal@igalia.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=samuel@sholland.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox