From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 60139D2FF for ; Sat, 14 Dec 2024 01:16:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734139019; cv=none; b=QNsYKfhxQ0jO/e+gvhpuM2SWJ19l3zryhdweURNHBVnoFl1oQtPtqr8OFnODQGxLe/czNNRVdpD75ka3y0D8KVrajpJhHCZJFepLZ5ACKDrlwsYklnHrs5AE6jQxEoxFKh1d+cFVOjcDybcUSrp+72Djk7eqsXv5IcXKuaDuB2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734139019; c=relaxed/simple; bh=gRyC+xG/KQ4DuOiTjuRdGZ1O0rJSxm4vq7H0bY1j6jk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BB/SpfEF/ZRI1mLsNdf0LjflyqX+zrjUawW0IfXF/XzYqdrgHOkMfc8fTGwkiOg686066F2vRCCyrQB812fUECMNCW/lEdJx67h1NYRuJZveJBgujDCQR5dM3qgOlY43bLUBt+QngN3dEmmlh7kB22leTYNS4m6jD+WgmCjB6Jg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B7EDE11FB; Fri, 13 Dec 2024 17:17:23 -0800 (PST) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 20AD63F5A1; Fri, 13 Dec 2024 17:16:54 -0800 (PST) Date: Sat, 14 Dec 2024 01:16:12 +0000 From: Andre Przywara To: Hermann.Lauer@uni-heidelberg.de Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Icenowy Zheng Subject: Re: [PATCH v2] ARM: dts: sun8i-r40: remove unused GPIO regulator Message-ID: <20241214011612.4fd9e4bf@minigeek.lan> In-Reply-To: <20241213195433.GA1568@lemon.iwr.uni-heidelberg.de> References: <20241213195433.GA1568@lemon.iwr.uni-heidelberg.de> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 13 Dec 2024 20:54:33 +0100 Hermann.Lauer@uni-heidelberg.de wrote: Hi, CC:ing Icenowy, who added the regulator originally, with commit 0ca12c1ee43c ("ARM: sun8i: r40: add 5V regulator for Banana Pi M2 Ultra"). Icenowy: can you clarify what "newer" version this was referring to in that commit message? That commit in itself doesn't seem to do anything, as the regulator isn't referenced, and it's not always-on. It's only later when the USB nodes were added that it got used? So was PH23 really necessary? As Hermann reports, setting PH23 on a v1.1 makes it reboot. > Subject: [PATCH v2] ARM: dts: sun8i-r40: remove unused GPIO regulator Hermann, this looks like an extra subject line here? > Banana Pi M2 Ultra V1.1 board resets immediately when the usb core tries > to setup PH23 GPIO. It turned out that the V1.0 board USB-A ports are > always power supplied and according to the board scheme PH23 is simply > not connected. > > So remove the PH23 setup: Doesn't harm V1.0 (with R40) and let V1.1 > (with A40i) start. > > Signed-off-by: Hermann Lauer The patch itself looks good to me, but it would be good to clarify the situation with the "older newer" version. Just in case: Reviewed-by: Andre Przywara Cheers, Andre > --- > V2: shorten subject, rm dangerous PH23 regulator completely > > diff --git a/arch/arm/boot/dts/allwinner/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/allwinner/sun8i-r40-bananapi-m2-ultra.dts > --- a/arch/arm/boot/dts/allwinner/sun8i-r40-bananapi-m2-ultra.dts > +++ b/arch/arm/boot/dts/allwinner/sun8i-r40-bananapi-m2-ultra.dts > @@ -91,15 +91,6 @@ > }; > }; > > - reg_vcc5v0: vcc5v0 { > - compatible = "regulator-fixed"; > - regulator-name = "vcc5v0"; > - regulator-min-microvolt = <5000000>; > - regulator-max-microvolt = <5000000>; > - gpio = <&pio 7 23 GPIO_ACTIVE_HIGH>; /* PH23 */ > - enable-active-high; > - }; > - > wifi_pwrseq: pwrseq { > compatible = "mmc-pwrseq-simple"; > reset-gpios = <&pio 6 10 GPIO_ACTIVE_LOW>; /* PG10 WIFI_EN */ > @@ -347,7 +338,5 @@ > }; > > &usbphy { > - usb1_vbus-supply = <®_vcc5v0>; > - usb2_vbus-supply = <®_vcc5v0>; > status = "okay"; > }; >