From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 161AE1D47D9; Tue, 17 Dec 2024 11:01:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734433319; cv=none; b=YwYorsNANi+iwXJVqnquZ0z2XmcQtHl87goSgpVKaVGJ+pouB2NK8tOfNViqhrvkwX8M0BPtSGOJYcvyCT2vSB789bir69riNDHQT5m9jb/urRmW8sEitNi0uckVRBJJAC9la/MeTt/sjkCbE+YA3860I/lpoGcTVrVTutAN45I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734433319; c=relaxed/simple; bh=NrqjMZ+J+2WHaZCrdfnIKMWsZCnqh8duGYd7H0hLNEo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Fr5NDVdNuWsC4v/dPEKc0P6qetjvvw7EaXaxwE0Q+9NAfc6fa0WuNPXf7V13L9YSdFdA05wod7k3wjmuQdyWKHQatyDt317VRyZ3RpgeJhbAUKqNgm2GaMFGQ5nmndzGt/fdvul9On3psexDFot+Ik/05812dxncNd0jhHndnTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6FFEA1063; Tue, 17 Dec 2024 03:02:23 -0800 (PST) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CE4E93F528; Tue, 17 Dec 2024 03:01:47 -0800 (PST) Date: Tue, 17 Dec 2024 11:01:40 +0000 From: Andre Przywara To: Wolfram Sang Cc: linux-rtc@vger.kernel.org, Alexandre Belloni , Yiting Deng , Xianwei Zhao , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Nicolas Ferre , Claudiu Beznea , Benson Leung , Guenter Roeck , Support Opensource , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Chanwoo Choi , Krzysztof Kozlowski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Eddie Huang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Orson Zhai , Baolin Wang , Chunyan Zhang , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Vincent Shih , Thierry Reding , Jonathan Hunter , Michal Simek , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH] rtc: use boolean values with device_init_wakeup() Message-ID: <20241217110140.22c92138@donnerap.manchester.arm.com> In-Reply-To: <20241217071331.3607-2-wsa+renesas@sang-engineering.com> References: <20241217071331.3607-2-wsa+renesas@sang-engineering.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 17 Dec 2024 08:13:26 +0100 Wolfram Sang wrote: > device_init_wakeup() second argument is a bool type. Use proper boolean > values when calling it to match the type and to produce unambiguous code > which is easier to understand. > > Signed-off-by: Wolfram Sang Verified via regexps that it's indeed this pattern: 1 => true, 0 => false. Reviewed-by: Andre Przywara Cheers, Andre > --- > Created with a coccinelle script. I opted for a single patch because the change > is rather trivial. I can break out per driver if this is desired. If you > like the change at all, that is. > > drivers/rtc/rtc-88pm80x.c | 2 +- > drivers/rtc/rtc-88pm860x.c | 2 +- > drivers/rtc/rtc-amlogic-a4.c | 6 +++--- > drivers/rtc/rtc-armada38x.c | 2 +- > drivers/rtc/rtc-as3722.c | 2 +- > drivers/rtc/rtc-at91rm9200.c | 2 +- > drivers/rtc/rtc-at91sam9.c | 2 +- > drivers/rtc/rtc-cadence.c | 2 +- > drivers/rtc/rtc-cmos.c | 2 +- > drivers/rtc/rtc-cpcap.c | 2 +- > drivers/rtc/rtc-cros-ec.c | 2 +- > drivers/rtc/rtc-da9055.c | 2 +- > drivers/rtc/rtc-ds3232.c | 2 +- > drivers/rtc/rtc-isl1208.c | 2 +- > drivers/rtc/rtc-jz4740.c | 2 +- > drivers/rtc/rtc-loongson.c | 4 ++-- > drivers/rtc/rtc-lp8788.c | 2 +- > drivers/rtc/rtc-lpc32xx.c | 2 +- > drivers/rtc/rtc-max77686.c | 2 +- > drivers/rtc/rtc-max8925.c | 2 +- > drivers/rtc/rtc-max8997.c | 2 +- > drivers/rtc/rtc-meson-vrtc.c | 2 +- > drivers/rtc/rtc-mpc5121.c | 2 +- > drivers/rtc/rtc-mt6397.c | 2 +- > drivers/rtc/rtc-mv.c | 4 ++-- > drivers/rtc/rtc-mxc.c | 2 +- > drivers/rtc/rtc-mxc_v2.c | 2 +- > drivers/rtc/rtc-omap.c | 2 +- > drivers/rtc/rtc-palmas.c | 2 +- > drivers/rtc/rtc-pic32.c | 2 +- > drivers/rtc/rtc-pm8xxx.c | 2 +- > drivers/rtc/rtc-pxa.c | 2 +- > drivers/rtc/rtc-rc5t583.c | 2 +- > drivers/rtc/rtc-rc5t619.c | 2 +- > drivers/rtc/rtc-renesas-rtca3.c | 2 +- > drivers/rtc/rtc-rk808.c | 2 +- > drivers/rtc/rtc-s3c.c | 2 +- > drivers/rtc/rtc-s5m.c | 2 +- > drivers/rtc/rtc-sa1100.c | 2 +- > drivers/rtc/rtc-sc27xx.c | 4 ++-- > drivers/rtc/rtc-sh.c | 2 +- > drivers/rtc/rtc-spear.c | 4 ++-- > drivers/rtc/rtc-sun6i.c | 2 +- > drivers/rtc/rtc-sunplus.c | 4 ++-- > drivers/rtc/rtc-tegra.c | 2 +- > drivers/rtc/rtc-test.c | 2 +- > drivers/rtc/rtc-tps6586x.c | 2 +- > drivers/rtc/rtc-tps65910.c | 2 +- > drivers/rtc/rtc-twl.c | 2 +- > drivers/rtc/rtc-wm831x.c | 2 +- > drivers/rtc/rtc-wm8350.c | 2 +- > drivers/rtc/rtc-xgene.c | 4 ++-- > drivers/rtc/rtc-zynqmp.c | 4 ++-- > 53 files changed, 62 insertions(+), 62 deletions(-) >