From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A406438385 for ; Wed, 1 Jan 2025 23:29:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735774197; cv=none; b=Xij61a3N+u6Pt0qw0fup0Z0SewLSJ/XVMu5HNjA6+8lxcu6Cahyd+n/SqOy3FK+n8FjfnLJdLgEyMII7ZmdSuOGKzF1DybECSvVJaG8OvoBnF+GSUVmEKCxKbFp6mO+YdQ3X+HCDbzdyHCdYs+0vBCpnMRGKwrBAVVGK7xjfF7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735774197; c=relaxed/simple; bh=DDHmBmkowkUOh8FcF//3ru+uUyuhtWiUORTAGPFWmzw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=S0a172cYoXXySiwuLa79+QpNDPcqt8OxK9tJ3Lo6A3VdIWYbnGowvY/TL41hmVCGW9S+jtqXcB6iIuDUKoeENpreNo1ElVKGloSEgIKJt5Cr6TMJCksIhTh0fYoQdQzJSj4F3zGz4CZtwdmpJCLyPbk2ziDltJMyYiW7eF47VM8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6435B11FB; Wed, 1 Jan 2025 15:30:16 -0800 (PST) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BF6643F6A8; Wed, 1 Jan 2025 15:29:46 -0800 (PST) Date: Wed, 1 Jan 2025 23:28:36 +0000 From: Andre Przywara To: Chen-Yu Tsai Cc: Stefan Gloor , robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jernej.skrabec@gmail.com, samuel@sholland.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: sunxi: Add MMC alias for consistent enumeration Message-ID: <20250101232836.76c7fd0e@minigeek.lan> In-Reply-To: References: <20241219105622.13691-2-code@stefan-gloor.ch> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 1 Jan 2025 16:58:28 +0800 Chen-Yu Tsai wrote: Hi, > On Thu, Dec 19, 2024 at 6:58=E2=80=AFPM Stefan Gloor wrote: > > > > Add explicit alias for MMC devices, so that (e)MMC and micro SD cards > > are enumerated consistently. This should fix spurious boot failures when > > specifying a hard-coded root partition, e.g., mmcblk0p2. =20 >=20 > IIRC we have chosen against adding explicit MMC aliases for the sunxi > platforms. Please try using UUID=3D or PARTUUID=3D for root partition > references. Yes, and LABEL=3D would be another way. Alternatively you could use U-Boot's DT when booting the board. U-Boot will add those aliases during build time (because it needs them for its own purposes), and by using $fdtcontroladdr (instead of $fdt_addr_r, on the bootz command line) you get this for free, and even save yourself from loading some DT. We sync the DTs regularly from the kernel to U-Boot now, and at the moment they are identical between the kernel and U-Boot, so you don't lose anything. Cheers, Andre > > Link: https://github.com/linux-sunxi/meta-sunxi/pull/431 > > Signed-off-by: Stefan Gloor > > --- > > arch/arm/boot/dts/allwinner/sun7i-a20-olinuxino-micro.dts | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm/boot/dts/allwinner/sun7i-a20-olinuxino-micro.dts = b/arch/arm/boot/dts/allwinner/sun7i-a20-olinuxino-micro.dts > > index a1b89b2a2999..9cd1eb690134 100644 > > --- a/arch/arm/boot/dts/allwinner/sun7i-a20-olinuxino-micro.dts > > +++ b/arch/arm/boot/dts/allwinner/sun7i-a20-olinuxino-micro.dts > > @@ -60,6 +60,8 @@ aliases { > > serial2 =3D &uart7; > > spi0 =3D &spi1; > > spi1 =3D &spi2; > > + mmc0 =3D &mmc0; > > + mmc1 =3D &mmc3; > > }; > > > > chosen { > > -- > > 2.45.2 > > > > =20 >=20