From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 964D21D86F7 for ; Fri, 11 Apr 2025 09:14:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744362847; cv=none; b=FAqoxYzCPPk9y82e4VIuDtW41TozkGiFcgyqo2AP1xPs41RtSfJNYGNV27NvtIFhjnwOCmVyxI6srR7h8JcD5xaKYxxKfurnC08FhAwmvpTbn7uoDV/WZ7jF10+WU6AtM0A4vCaFfwOq3GrzAXkEj5PgBLH8Ck/GnGz+SfXzfbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744362847; c=relaxed/simple; bh=E7a+VLvOKB5W9tiYzsAlpLHLtnyCT6ABiTee8X7K0bI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XxKJxfOoCcKpeB6gFMj6z9q0WJKnew/LHAZIVmDOcfPGWhM79Ufm4VWM1tTZI6ix3s4OmX+Mt0t6QbgdA6fqLjC6t2Ualu0kZCO0eksMMPDjE1QYC8k2YUQKsnhpQF86EkSOq30qAYOT5B1B+bL6v3vHutYEbCg01BBjufoP2TY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 627F2106F; Fri, 11 Apr 2025 02:14:04 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9DCDD3F6A8; Fri, 11 Apr 2025 02:14:01 -0700 (PDT) Date: Fri, 11 Apr 2025 10:13:58 +0100 From: Andre Przywara To: iuncuim Cc: Vasily Khoruzhick , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "Rafael J . Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , , , , , , Piotr Oniszczuk Subject: Re: [PATCH 6/6] dt-bindings: thermal: sun8i: Add A523 THS0/1 controllers Message-ID: <20250411101358.03b100ba@donnerap.manchester.arm.com> In-Reply-To: <20250410165044.766460-7-iuncuim@gmail.com_quarantine> References: <20250410165044.766460-1-iuncuim@gmail.com> <20250410165044.766460-7-iuncuim@gmail.com_quarantine> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 11 Apr 2025 00:50:44 +0800 iuncuim wrote: Hi Mikhail, many thanks for sending! This patch needs to come earlier in the series, before the .dts patches, and I think ideally even before the driver patches. The repo needs to be clean at any given commit, as it stands right now the DT validation would fail if run on patch 5/6 only. More below... > From: Mikhail Kalashnikov > > Add dt-bindings description of the thermal sensors in the A523 processor. > > Signed-off-by: Mikhail Kalashnikov > --- > .../bindings/thermal/allwinner,sun8i-a83t-ths.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > index 3e61689f6..70ac395ef 100644 > --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > @@ -24,17 +24,21 @@ properties: > - allwinner,sun50i-h5-ths > - allwinner,sun50i-h6-ths > - allwinner,sun50i-h616-ths > + - allwinner,sun55i-a523-ths0 > + - allwinner,sun55i-a523-ths1 > > clocks: > minItems: 1 > items: > - description: Bus Clock > + - description: GPADC Clock The new clock needs to come last, to preserve the order for the existing chips. > - description: Module Clock > > clock-names: > minItems: 1 > items: > - const: bus > + - const: gpadc Same here, of course. And don't you need to adjust the number of clocks in the allOf: section below, to require exactly three clocks for the A523? Cheers, Andre > - const: mod > > reg: > @@ -107,6 +111,7 @@ allOf: > enum: > - allwinner,sun8i-h3-ths > - allwinner,sun20i-d1-ths > + - allwinner,sun55i-a523-ths0 > > then: > properties: