From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 69EA32528E1 for ; Tue, 15 Apr 2025 23:07:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744758423; cv=none; b=pfn7a2lVzx/qyl1fki3ibzgcO7abowZy6H4Icyk7+qwOiR6MuXTEB3i2L36rjdNuqkCc+HNsecEoZEbv9fMqTRRSTeGYM1K7KqojAfK3psbBqva+WcJkgWA/SCFtFbqHJhJQhKyHBo+W+9lPJpIetw7llVsJvtTBll6Ezt0Itvg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744758423; c=relaxed/simple; bh=1lGlyKBNyc01n9+Wc5py3woSkLFEodebESQ0d6+hpcU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Y3a3aFl0ZqwqrGImKOTCa2ucC5sZ9vs+ZgGCdmxAzLaGgD+ztxxKicdb0/uyUTvvIDct/MyPQ1P72DGWc6KRCctvSGMMCSlMhfK2+k5HghZ9uXrwo540cuEbd7ceDPJiSU5TsMiCNFAq/T9BtuSYlmW3EdTkQM/p4zfgfNvPLfE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7C9C4339; Tue, 15 Apr 2025 16:06:58 -0700 (PDT) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5ECB53F59E; Tue, 15 Apr 2025 16:06:59 -0700 (PDT) Date: Wed, 16 Apr 2025 00:06:00 +0100 From: Andre Przywara To: Jernej Skrabec Cc: jagan@amarulasolutions.com, trini@konsulko.com, macromorgan@hotmail.com, uwu@icenowy.me, u-boot@lists.denx.de, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 3/5] sunxi: H6: DRAM: Constify function parameters Message-ID: <20250416000600.24fdc69f@minigeek.lan> In-Reply-To: <20250411161439.4743-4-jernej.skrabec@gmail.com> References: <20250411161439.4743-1-jernej.skrabec@gmail.com> <20250411161439.4743-4-jernej.skrabec@gmail.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 11 Apr 2025 18:14:37 +0200 Jernej Skrabec wrote: Hi, > Constify parameters for two reasons: > - Allow more compile time optimizations > - It will allow later sharing of common code with H616 (when it will be > rearranged some more) > > Commit does same kind of changes as 457e2cd665bd ("sunxi: H616: dram: > const-ify DRAM function parameters") Makes sense, and indeed all those functions only read from para: > Signed-off-by: Jernej Skrabec Reviewed-by: Andre Przywara Cheers, Andre > --- > arch/arm/mach-sunxi/dram_sun50i_h6.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/arch/arm/mach-sunxi/dram_sun50i_h6.c b/arch/arm/mach-sunxi/dram_sun50i_h6.c > index 0adbda756639..24b2cb1579f4 100644 > --- a/arch/arm/mach-sunxi/dram_sun50i_h6.c > +++ b/arch/arm/mach-sunxi/dram_sun50i_h6.c > @@ -34,13 +34,13 @@ > * similar PHY is ZynqMP. > */ > > -static void mctl_sys_init(struct dram_para *para); > -static void mctl_com_init(struct dram_para *para); > -static bool mctl_channel_init(struct dram_para *para); > +static void mctl_sys_init(u32 clk_rate); > +static void mctl_com_init(const struct dram_para *para); > +static bool mctl_channel_init(const struct dram_para *para); > > static bool mctl_core_init(struct dram_para *para) > { > - mctl_sys_init(para); > + mctl_sys_init(para->clk); > mctl_com_init(para); > switch (para->type) { > case SUNXI_DRAM_TYPE_LPDDR3: > @@ -150,7 +150,7 @@ static void mctl_set_master_priority(void) > MBUS_CONF(HDCP2, true, HIGH, 2, 100, 64, 32); > } > > -static void mctl_sys_init(struct dram_para *para) > +static void mctl_sys_init(u32 clk_rate) > { > struct sunxi_ccm_reg * const ccm = > (struct sunxi_ccm_reg *)SUNXI_CCM_BASE; > @@ -171,7 +171,7 @@ static void mctl_sys_init(struct dram_para *para) > > /* Set PLL5 rate to doubled DRAM clock rate */ > writel(CCM_PLL5_CTRL_EN | CCM_PLL5_LOCK_EN | > - CCM_PLL5_CTRL_N(para->clk * 2 / 24), &ccm->pll5_cfg); > + CCM_PLL5_CTRL_N(clk_rate * 2 / 24), &ccm->pll5_cfg); > mctl_await_completion(&ccm->pll5_cfg, CCM_PLL5_LOCK, CCM_PLL5_LOCK); > > /* Configure DRAM mod clock */ > @@ -196,7 +196,7 @@ static void mctl_sys_init(struct dram_para *para) > writel(0x8000, &mctl_ctl->unk_0x00c); > } > > -static void mctl_set_addrmap(struct dram_para *para) > +static void mctl_set_addrmap(const struct dram_para *para) > { > struct sunxi_mctl_ctl_reg * const mctl_ctl = > (struct sunxi_mctl_ctl_reg *)SUNXI_DRAM_CTL0_BASE; > @@ -282,7 +282,7 @@ static void mctl_set_addrmap(struct dram_para *para) > mctl_ctl->addrmap[8] = 0x3F3F; > } > > -static void mctl_com_init(struct dram_para *para) > +static void mctl_com_init(const struct dram_para *para) > { > struct sunxi_mctl_com_reg * const mctl_com = > (struct sunxi_mctl_com_reg *)SUNXI_DRAM_COM_BASE; > @@ -352,7 +352,7 @@ static void mctl_com_init(struct dram_para *para) > } > } > > -static void mctl_bit_delay_set(struct dram_para *para) > +static void mctl_bit_delay_set(const struct dram_para *para) > { > struct sunxi_mctl_phy_reg * const mctl_phy = > (struct sunxi_mctl_phy_reg *)SUNXI_DRAM_PHY0_BASE; > @@ -411,7 +411,7 @@ static void mctl_bit_delay_set(struct dram_para *para) > } > } > > -static bool mctl_channel_init(struct dram_para *para) > +static bool mctl_channel_init(const struct dram_para *para) > { > struct sunxi_mctl_com_reg * const mctl_com = > (struct sunxi_mctl_com_reg *)SUNXI_DRAM_COM_BASE;