Re: b4 thank-you letter shows incorrect repo URL

[Konstantin Ryabitsev <konstantin@linuxfoundation.org>]

On Thu, May 01, 2025 at 11:49:38PM +0800, Chen-Yu Tsai wrote:
> > > This is coming from your custom template, not from b4 itself. By default, b4
> > > just says "Applied to ${branch}".
> >
> > My template is: "Applied to ${branch} in ${treename}, thanks!"
> >
> > My .git/config is as follows:
> >
> > [remote "sunxi"]
> >         url = git@github.com:linux-sunxi/linux-sunxi.git
> >         tagopt = --no-tags
> >         fetch = +refs/heads/*:refs/remotes/sunxi-github/*
> > [remote "sunxi-korg"]
> >         url = https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git
> >         pushURL = git@gitolite.kernel.org:pub/scm/linux/kernel/git/sunxi/linux
> >         fetch = +refs/heads/*:refs/remotes/sunxi-korg/*
> >         tagopt = --no-tags
> >         b4-commit-url-mask = https://git.kernel.org/sunxi/linux/c/%.12s
> >
> > Also, the branch I applied it to is named "sunxi/clk-fixes-for-6.15",
> > both locally and in the kernel.org repo, not "clk-fixes-for-6.15" as
> > shown in the original thank-you email.
> >
> > I think there is a parsing error somewhere. Maybe b4 isn't dealing with
> > nested branch names correctly and somehow thinks the "sunxi/" part is
> > actually the remote name.
> >
> > If I rename the "sunxi" remote to "sunxi-github", `b4 ty` now generates:
> >
> >     Applied to sunxi/clk-fixes-for-6.15 in local tree, thanks!
> >
> > Again this seems to point to accidentally treating part of the branch name
> > as the remote name.
> 
> Also, I found a thank-you letter that is correct that is from Jan. 2025:
> 
>     https://lore.kernel.org/linux-sunxi/173617837421.3282465.589306007023383641.b4-ty@csie.org/
> 
> The next one that I found was incorrect. This one is from Feb. 2025:
> 
>     https://lore.kernel.org/linux-sunxi/173909140135.1184685.5784910677727356231.b4-ty@csie.org/
> 
> Though it could be I upgraded something on my workstation some time
> in between.

Yes, I think there's a substring/partial match that causes this.

I'll take a look.

bugspray tag me

-K