From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.thorsis.com (mail.thorsis.com [217.92.40.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6543B224AE4 for ; Thu, 8 May 2025 12:10:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.92.40.78 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746706250; cv=none; b=TmrIkrklUVbV3N2XvKrVbueUPDKFEW5wencN761iEXUGejUbPfr4YpPfJZI62B695OdiKnRWrD0/5+0hFPKoaYPhz7B4HvWqhYyXdjHGwAlEPWP00wAjeOkNndE5NF0zu9cor2kSK4P6VxRbG2B0l0kcUmsQ71Yz4yG8MyUj7co= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746706250; c=relaxed/simple; bh=HmZK9JZOA2Q9fjChjb96bqxOPBEDH70vQ+8hoaBSyxQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XcPF0T1fQNbDwnuQTYhLBMferXfYuHz6pQTJMp6rOP+8O+yR089nPg0dxgJR8u/TS/kdZZYCSNzmv3yDrXEMkhI6uwzXMH2M69WOp9VNyzr4918+hPAuHlUgyTfHJRdn+xhLoF9Gos4lffv21k0YuOr1loRMlVd8e+8n9Uyh9lw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=thorsis.com; spf=pass smtp.mailfrom=thorsis.com; dkim=pass (2048-bit key) header.d=thorsis.com header.i=@thorsis.com header.b=D009CDIO; arc=none smtp.client-ip=217.92.40.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=thorsis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thorsis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thorsis.com header.i=@thorsis.com header.b="D009CDIO" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 0AF7114800B7; Thu, 8 May 2025 14:05:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1746705914; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=QlRB9Iaokfu0oipHLYE3CeIxI9maDwC7586JM6Zrrcs=; b=D009CDIO4uX44xO7JFbCItOhC77Mhdg1qz/LCj1MPQummr1uvp6uLhO14nYwCQbamhPH1m J4c+BPCmtCJ3iRq65gWS0BdqEXeKQMLIaz7WGMUauKPvAJSAQu1kmDT5Wi5ufXQoB+l4NZ T4HIhGpm276h0WvaRvgeSbtc3jWvYsfni4jgFzAYgDMR7Sx/L+NRkfPJMshTaHrUVlb3WW 7nKVWDSw1JIAPI0LBLnghBb7S0qAvYKezgfyNgl5aOQwkLwuZAo4QEL2RExD1Llu+phqjG 2EmE6QmVpj7oT36SECecjm+USZfsC2QtC2HVno7OpWrjA8UVpbCC2FKc7xDTrg== Date: Thu, 8 May 2025 14:05:07 +0200 From: Alexander Dahl To: Michael Klein Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: dts: bananapi: add support for PHY LEDs Message-ID: <20250508-strategy-simmering-20a48db6b6dd@thorsis.com> Mail-Followup-To: Michael Klein , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org References: <20250507182005.8660-1-michael@fossekall.de> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250507182005.8660-1-michael@fossekall.de> User-Agent: Mutt/2.2.12 (2023-09-09) X-Last-TLS-Session-Version: TLSv1.3 Hallo Michael, Am Wed, May 07, 2025 at 08:20:04PM +0200 schrieb Michael Klein: > The RTL8211E ethernet PHY driver has recently gained support for > controlling PHY LEDs via /sys/class/leds. The Bananapi M1 has three > LEDs connected to the RTL8211E PHY. Add the corresponding nodes to > the device tree. > > v2: Refine commit message This changelog should usually go below the '---' so it won't end up in the commit message, but in the e-mail only. Greets Alex > > Signed-off-by: Michael Klein > --- > .../boot/dts/allwinner/sun7i-a20-bananapi.dts | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts > index 46ecf9db2324..d8b362c9661a 100644 > --- a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts > +++ b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts > @@ -48,6 +48,7 @@ > > #include > #include > +#include > > / { > model = "LeMaker Banana Pi"; > @@ -169,6 +170,32 @@ &ir0 { > &gmac_mdio { > phy1: ethernet-phy@1 { > reg = <1>; > + > + leds { > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@0 { > + reg = <0>; > + color = ; > + function = LED_FUNCTION_LAN; > + linux,default-trigger = "netdev"; > + }; > + > + led@1 { > + reg = <1>; > + color = ; > + function = LED_FUNCTION_LAN; > + linux,default-trigger = "netdev"; > + }; > + > + led@2 { > + reg = <2>; > + color = ; > + function = LED_FUNCTION_LAN; > + linux,default-trigger = "netdev"; > + }; > + }; > }; > }; > > -- > 2.39.5 > >