From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5626420FA96 for ; Fri, 9 May 2025 14:32:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746801131; cv=none; b=AO4HUXAlwVipI2IJZ6sCYQDpBRRO0oSgki+Ph5erKVLhOym+wIi7pyRNIEyVC3N9A5SYskFs/wZDT8SxlCwQXLGdTzCoRVPJ040EpSyCcxXMRgOjoYx1YNiX+IVDlwkUpGEGuk/NyyUuqLWpZRujm0JSG2HgKjfG/c2X76EU1ns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746801131; c=relaxed/simple; bh=f2vq0e8Pp2Hw73GaM9PcNDnYA+fX1vXvQHuMzGqtCiY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cRcEFqabGZG/3QOL9jr5gsTpgcCt696wAJoBjC1evvq/WVNX9st55grvsU3oPWmxUFAnDSw8op2D3sz8Udvun2h1oVKxyJJojL8XAq9gwbBGSyKoS2xxR/1q2lqJgkBSak9Y1ec5N1ESFrUkF28P6sDTO5BMgJvfm3MWTuRozYA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B67FF1595; Fri, 9 May 2025 07:31:58 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 041953F5A1; Fri, 9 May 2025 07:32:06 -0700 (PDT) Date: Fri, 9 May 2025 15:32:04 +0100 From: Andre Przywara To: Chris Morgan Cc: linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, ryan@testtoast.com, macromorgan@hotmail.com, p.zabel@pengutronix.de, tzimmermann@suse.de, maarten.lankhorst@linux.intel.com, simona@ffwll.ch, airlied@gmail.com, mripard@kernel.org, samuel@sholland.org, jernej.skrabec@gmail.com, wens@csie.org, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org Subject: Re: [PATCH V9 23/24] arm64: dts: allwinner: rg35xx: Add GPIO backlight control Message-ID: <20250509153204.05317413@donnerap.manchester.arm.com> In-Reply-To: <20250507201943.330111-24-macroalpha82@gmail.com> References: <20250507201943.330111-1-macroalpha82@gmail.com> <20250507201943.330111-24-macroalpha82@gmail.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 7 May 2025 15:19:42 -0500 Chris Morgan wrote: Hi Chris, > From: Chris Morgan > > The LCD backlight for this device can be exposed as a simple GPIO- > controlled device. It would be more accurately modelled using PWM to > enable brightness control, however the PWM driver design for the H616 is > not yet upstreamed. I don't think this is right then: First there should be no notion of a "driver being upstreamed" in a *DT* patch, as "the driver" is a Linux speciality, which the DT itself doesn't care about. And secondly we should not chicken out and go with an interim solution. So I guess we need to wait for the PWM binding to appear. Cheers, Andre > Add a GPIO backlight node to the DTS. > > Signed-off-by: Ryan Walklin > Signed-off-by: Chris Morgan > --- > .../boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-2024.dts | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-2024.dts b/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-2024.dts > index 7e17ca07892d..95f2ae04bd95 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-2024.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-2024.dts > @@ -21,6 +21,12 @@ aliases { > serial0 = &uart0; > }; > > + backlight: backlight { > + compatible = "gpio-backlight"; > + gpios = <&pio 3 28 GPIO_ACTIVE_HIGH>; // PD28 > + default-on; > + }; > + > battery: battery { > compatible = "simple-battery"; > constant-charge-current-max-microamp = <1024000>;