From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF70F1E8328; Mon, 2 Jun 2025 09:55:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748858146; cv=none; b=DYPZ0GKmoWMIglQMV3v1YZ9m9KBlihnBVxYaZxVHt6vGtttAjcuW/wYUj4i1kv/7UfGjs8jDhkxQEoTZ0bjdlPNsBdyYiYW08O/AHv0N8r1E2UtLbmISmcXhCJYk21ebPbYiUWMznnUrHqi6l+WCXvBQIomXzznSp00Ct47/3DA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748858146; c=relaxed/simple; bh=f3PThskvyc3o1dRe3gR60NcQON7tJMiafQa3JgdKS4g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uTQKwRjZNz3IiWj6s5SAMkTCb1GiDCGayK4JvKn3HCFpa97/mzUUmvFZpkQOph/CrlyKWjmcaqHNpQz3U1IiZRFssPIRqyHE1VspTGoC5uIGAagWWPjReEqgbQLyGJCwwkK4Ndhz6CGvveGTVHQoquaedYXqEH0Lc7m8duoCT6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=owoclCnU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="owoclCnU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AAD3C4CEEB; Mon, 2 Jun 2025 09:55:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748858146; bh=f3PThskvyc3o1dRe3gR60NcQON7tJMiafQa3JgdKS4g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=owoclCnU402xj1tKfjG2V3nRezynaK54F0LeM1C7LfPj5B6kEEc+R6xwRDWTX9Izt fH4bF1SyqYcU4bzfflH7O+/vuVhM1ipyqI5itPn188lgbOxXSl16Vj9bbUSHwPJsAV 8jvPUNNMaaTUaPhWg+kdP52Xd/CbCrw3Vxy0DF5tZ3R/Je8tIWBrTlHG3v5WFeRVJt yvNeq9RShmce2SQXZ+h+jwC5cyhw10/yBr8htEymYu0oSgwmd846TUElCHbXtoAysE 4Rlp6tzntGAPZEJHasqpvFqUjN/otT7Elj1N1qpY5NxxEVSfyU/eHW+psb3/D8MBIn dRGSN1IypgS9A== Date: Mon, 2 Jun 2025 11:55:44 +0200 From: Maxime Ripard To: Michael Cc: Chen-Yu Tsai , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jernej Skrabec , Samuel Holland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, regressions@lists.linux.dev Subject: Re: [REGRESSION] [BISECTED] drm/sun4i: hdmi: No HDMI output with BananaPI M1 on 6.9 Message-ID: <20250602-psychedelic-purring-poodle-900a5b@houat> References: <20250526-refined-dog-of-blizzard-b48f11@houat> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="bjexc5aylm7p2ugp" Content-Disposition: inline In-Reply-To: --bjexc5aylm7p2ugp Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [REGRESSION] [BISECTED] drm/sun4i: hdmi: No HDMI output with BananaPI M1 on 6.9 MIME-Version: 1.0 On Mon, May 26, 2025 at 11:13:01PM +0200, Michael wrote: > On Mon, May 26, 2025 at 07:30:35PM +0200, Maxime Ripard wrote: > > On Mon, May 12, 2025 at 10:27:06PM +0200, Michael wrote: > > > with v6.9 and later there is no output on the BananaPI HDMI connector. > > >=20 > > > I have bisected the issue to the following commit: > > >=20 > > > 358e76fd613a ("drm/sun4i: hdmi: Consolidate atomic_check and mode_v= alid") > > >=20 > > > With this patch, sun4i_hdmi_connector_clock_valid() is occasionally c= alled > > > with clock=3D0, causing the function to return MODE_NOCLOCK. > > > In the old sun4i_hdmi_mode_valid() before the patch, mode->clock is > > > always!=3D0, maybe that gives someone a hint. > >=20 > > This doesn't make sense to me, if only because the two callers of > > tmds_char_rate_valid (hdmi_compute_clock and > > drm_hdmi_connector_mode_valid) have, right before calling it, checks to > > make sure the clock rate isn't 0, and would return MODE_ERROR or EINVAL > > in such a case. > >=20 > > https://elixir.bootlin.com/linux/v6.15/source/drivers/gpu/drm/display/d= rm_hdmi_state_helper.c#L234 > > https://elixir.bootlin.com/linux/v6.15/source/drivers/gpu/drm/display/d= rm_hdmi_state_helper.c#L553 >=20 > Before 6.14, sun4i_hdmi_connector_clock_valid() was also called from > sun4i_hdmi_connector_atomic_check()... >=20 > > Do you have some logs (with dri.devel=3D0xff)? Does it happen with 6.15= as > > well? >=20 > It does not happen with 6.15, as it was fixed in 6.14 with 84e541b1e58e > ("drm/sun4i: use drm_atomic_helper_connector_hdmi_check()"). Then we might still need to backport that patch. Does applying it to 6.9 alone makes it work, or do you need some additional= ones (I'm thinking of ae048fc4f96d in particular, which in turn would require 47368ab437fd) Maxime --bjexc5aylm7p2ugp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCaD11GwAKCRAnX84Zoj2+ drKQAYC96lg5+YW34Em5Duc/MTJOq0c14NGmAiHXTxuOqNkljUIBqho6t3MeKTO6 M6+OuV0BfR7FKf+9atUl2aa7s8n1k/MKwABVR/aK6AWGsPaqvm4doIaoMO5ji47F Lsgy23oivw== =0IgN -----END PGP SIGNATURE----- --bjexc5aylm7p2ugp--