From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6A8982CA6 for ; Sat, 5 Jul 2025 07:37:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751701053; cv=none; b=kWY8S0SAldpLUqE3YfPUOcLmGsPtdPEzzMTrH0x2jBg7FHdUSqeotjLylt9FGcT+q/d7avcPKvjTf/GjQF9njOFug7sa27BZZSR8lSOrCIZHEPxssULpEGUZCNj/jc9vIWSUuEyJUjhiseVQwGCI5noBoxccc9wKsi6MDBN5l/k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751701053; c=relaxed/simple; bh=RSEN/2TWL3Q95UPQ30ZbVUKp/ioML++whRQBV7x0Oxg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GHncFP5T19fsoyuMBR7TDp6eHUg5Jhvn9gR5mgbulYal7COw72dZme3AKRfiRl3gBSiwUUbcz/8F2L1EVXpQz1Rgvk4Z6S5FhXtgwMR82EPJY79fz9sb+Fdnhfs+Kcu0MyfrI8/YS6bfcArm0zs74tlazUxTcHlX7dOsANhZkH0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 01A61153B; Sat, 5 Jul 2025 00:37:17 -0700 (PDT) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 785EA3F6A8; Sat, 5 Jul 2025 00:37:28 -0700 (PDT) Date: Sat, 5 Jul 2025 08:36:00 +0100 From: Andre Przywara To: Chen-Yu Tsai Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH net 0/2] allwinner: a523: Rename emac0 to gmac0 Message-ID: <20250705083600.2916bf0c@minigeek.lan> In-Reply-To: <20250628054438.2864220-1-wens@kernel.org> References: <20250628054438.2864220-1-wens@kernel.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 28 Jun 2025 13:44:36 +0800 Chen-Yu Tsai wrote: Hi, > From: Chen-Yu Tsai > > Hi folks, > > This small series aims to align the name of the first ethernet > controller found on the Allwinner A523 SoC family with the name > found in the datasheets. It renames the compatible string and > any other references from "emac0" to "gmac0". To be honest I am not a big fan of those cosmetic renames when it touches DT files. It seems to not break compatibility in this case, since we don't use the specific compatible string, but leaves a bitter taste anyway. Also I pick DT patches out of -rc releases for U-Boot, and did so internally already, so it's not without churns. So is this really necessary, and what is the purpose of this patch? I am fine with using GMAC for the GMAC200 part in the SoC, but the A64, H6, H616, A133 all use the same IP - as the fallback compatible proves - and they call it all EMAC. That's not a NAK, but just wanted to bring this up. Cheers, Andre. > When support of the hardware was introduced, the name chosen was > "EMAC", which followed previous generations. However the datasheets > use the name "GMAC" instead, likely because there is another "GMAC" > based on a newer DWMAC IP. > > The first patch fixes the compatible string entry in the device tree > binding. > > The second patch fixes all references in the existing device trees. > > Since this was introduced in v6.16-rc1, I hope to land this for v6.16 > as well. > > There's a small conflict in patch one around the patch context with > > dt-bindings: net: sun8i-emac: Add A100 EMAC compatible > > that just landed in net-next today. I will leave this patch to the net > mainainers to merge to avoid making a bigger mess. Once that is landed > I will merge the second patch through the sunxi tree. > > > Thanks > ChenYu > > > Chen-Yu Tsai (2): > dt-bindings: net: sun8i-emac: Rename A523 EMAC0 to GMAC0 > arm64: dts: allwinner: a523: Rename emac0 to gmac0 > > .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 2 +- > arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 6 +++--- > arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dts | 4 ++-- > arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts | 4 ++-- > 4 files changed, 8 insertions(+), 8 deletions(-) >