From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 22661EADC for ; Mon, 15 Sep 2025 15:36:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757950604; cv=none; b=QoTB9JRRC1BcWjBUkG8prrkBQJsB9S3QAC3jQ30gjtUohW8zLa6L4V20RiG2ZDPOshWNIJ3vTT6HrG1KTPI4AWraa+Wtc+Oo7vdHU0p/630xXyLZY6yOdhdKiGiMWKZRse5iwm4f2dtle/FRWw16Uy0EpZIiNhF1Kl/5Xf2Xaxo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757950604; c=relaxed/simple; bh=3ibAw1ckGGL6F3fg13ZCLWL8/qyUj6I4RBjpKX3YopM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ANYTy9PKRBa9Bx6wvHai96eIgRSMAbDrSen3gYSjhykxsBRO67BJBPw/KrEK2WbY89OIufo8qR5Riw/0blbIgrKtcEZpAOL34Xhm+mwws/ghqQQ4OlxExnpqKOdrvbATv4sc+E5oEKU+ghQxXfWtN8oF+B0ZrMd8E2ljX0d5GR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E606A1424; Mon, 15 Sep 2025 08:36:32 -0700 (PDT) Received: from donnerap (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 46F8F3F694; Mon, 15 Sep 2025 08:36:40 -0700 (PDT) Date: Mon, 15 Sep 2025 16:36:37 +0100 From: Andre Przywara To: Lukas Schmid Cc: Tom Rini , u-boot@lists.denx.de, "linux-sunxi@lists.linux.dev" , =?UTF-8?B?QW5kcsOhcyBTemVtesWR?= Subject: Re: [PATCH v1 1/1] sunxi: extend R528/T113-s3/D1(s) DRAM initialisation Message-ID: <20250915163637.38d05aab@donnerap> In-Reply-To: <20250914144411.157826-1-lukas.schmid@netcube.li> References: <20250914144411.157826-1-lukas.schmid@netcube.li> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 14 Sep 2025 16:44:11 +0200 Lukas Schmid wrote: Hi Lukas, thanks for the patch! CC:ing the sunxi list and Andr=C3=A1s, who I think has some T113-s4 device = as well. It would be good to see some Tested-by: tags, but otherwise the patch looks good, I'd say. Also I hear that awboot uses 0x6800 as the chip ID for the -s4, can someone shed some light on this? Cheers, Andre > Extend the DRAM initialisation code to add support for the T113-S4 aka > T113M4020DC0 by checking the SoC's CHIPID. >=20 > Signed-off-by: Lukas Schmid > --- > drivers/ram/sunxi/dram_sun20i_d1.c | 13 ++++++++++++- > drivers/ram/sunxi/dram_sun20i_d1.h | 7 +++++++ > 2 files changed, 19 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/ram/sunxi/dram_sun20i_d1.c b/drivers/ram/sunxi/dram_= sun20i_d1.c > index a1794032f3b..01d19d5feaa 100644 > --- a/drivers/ram/sunxi/dram_sun20i_d1.c > +++ b/drivers/ram/sunxi/dram_sun20i_d1.c > @@ -54,6 +54,11 @@ static void sid_read_ldoB_cal(const dram_para_t *para) > clrsetbits_le32(0x3000150, 0xff00, reg << 8); > } > =20 > +static u32 sid_read_soc_chipid(void) > +{ > + return readl(SUNXI_SID_BASE + 0x00) & 0xffff; > +} > + > static void dram_voltage_set(const dram_para_t *para) > { > int vol; > @@ -663,6 +668,7 @@ static void mctl_phy_ac_remapping(const dram_para_t *= para, > =20 > fuse =3D (readl(SUNXI_SID_BASE + 0x28) & 0xf00) >> 8; > debug("DDR efuse: 0x%x\n", fuse); > + debug("SoC Chip ID: 0x%08x\n", sid_read_soc_chipid()); > =20 > if (para->dram_type =3D=3D SUNXI_DRAM_TYPE_DDR2) { > if (fuse =3D=3D 15) > @@ -675,7 +681,12 @@ static void mctl_phy_ac_remapping(const dram_para_t = *para, > switch (fuse) { > case 8: cfg =3D ac_remapping_tables[2]; break; > case 9: cfg =3D ac_remapping_tables[3]; break; > - case 10: cfg =3D ac_remapping_tables[5]; break; > + case 10: > + if (sid_read_soc_chipid() =3D=3D SUNXI_CHIPID_T113M4020DC0) > + cfg =3D ac_remapping_tables[0]; > + else > + cfg =3D ac_remapping_tables[5]; > + break; > case 11: cfg =3D ac_remapping_tables[4]; break; > default: > case 12: cfg =3D ac_remapping_tables[1]; break; > diff --git a/drivers/ram/sunxi/dram_sun20i_d1.h b/drivers/ram/sunxi/dram_= sun20i_d1.h > index 91383f6cf10..7bd8f67a77a 100644 > --- a/drivers/ram/sunxi/dram_sun20i_d1.h > +++ b/drivers/ram/sunxi/dram_sun20i_d1.h > @@ -19,6 +19,13 @@ enum sunxi_dram_type { > SUNXI_DRAM_TYPE_LPDDR3 =3D 7, > }; > =20 > +enum sunxi_soc_chipid { > + SUNXI_CHIPID_F133A =3D 0x5C00, > + SUNXI_CHIPID_D1S =3D 0x5E00, > + SUNXI_CHIPID_T113S3 =3D 0x6000, > + SUNXI_CHIPID_T113M4020DC0 =3D 0x7200, > +}; > + > /* > * This structure contains a mixture of fixed configuration settings, > * variables that are used at runtime to communicate settings between