public inbox for linux-sunxi@lists.linux.dev
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Yixun Lan <dlan@gentoo.org>
Cc: u-boot@lists.denx.de, linux-sunxi@lists.linux.dev,
	Jagan Teki <jagan@amarulasolutions.com>,
	Tom Rini <trini@konsulko.com>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Paul Kocialkowski <contact@paulk.fr>,
	Samuel Holland <samuel@sholland.org>
Subject: Re: [PATCH v2 02/10] sunxi: spl: a733: config text and stack address
Date: Fri, 2 Jan 2026 01:40:33 +0100	[thread overview]
Message-ID: <20260102014033.26410b4c@minigeek.lan> (raw)
In-Reply-To: <20251130-01-a733-soc-support-v2-2-18bdd4376fad@gentoo.org>

On Sun, 30 Nov 2025 21:45:11 +0000
Yixun Lan <dlan@gentoo.org> wrote:

> Add some ciritial SPL settings for A733 SoC
> 
> - Set SPL MAX SIZE to 180KB, 0x47000 - 0x74000
> - Set SPL running address to 0x47000, with a header padded before
>   the image, so the final SPL text address need to shift 0x60 bytes.
> - Set Stack address

The patch separation for those addresses looks a bit arbitrary, since
there are other SPL specific addresses in patch 01/10, and we don't
really support an SPL anyway.
So either drop this patch, or merge it into the previous one.

Cheers,
Andre

> 
> Signed-off-by: Yixun Lan <dlan@gentoo.org>
> ---
>  common/spl/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> index 24d6ce5d739..ba98b76bbc6 100644
> --- a/common/spl/Kconfig
> +++ b/common/spl/Kconfig
> @@ -81,6 +81,7 @@ config SPL_MAX_SIZE
>  	default 0xec00 if OMAP34XX
>  	default 0x10000 if ARCH_MX6 && !MX6_OCRAM_256KB
>  	default 0xbfa0 if MACH_SUN50I_H616 || MACH_SUN50I_A133 || MACH_SUN55I_A523
> +	default 0x2d000 if MACH_SUN60I_A733
>  	default 0x7000 if RCAR_GEN3
>  	default 0x5fa0 if SUNXI_SRAM_ADDRESS = 0x0
>  	default 0x7fa0 if ARCH_SUNXI
> @@ -279,6 +280,7 @@ config SPL_TEXT_BASE
>  	default 0x40301350 if OMAP54XX
>  	default 0x10060 if MACH_SUN50I || MACH_SUN50I_H5 || MACH_SUN9I
>  	default 0x44060 if MACH_SUN55I_A523
> +	default 0x47060 if MACH_SUN60I_A733
>  	default 0x20060 if SUN50I_GEN_H6 || SUNXI_GEN_NCAT2
>  	default 0x00060 if ARCH_SUNXI
>  	default 0xfffc0000 if ARCH_ZYNQMP
> @@ -434,6 +436,7 @@ config SPL_STACK
>  	default 0x52a00 if MACH_SUN50I_H616
>  	default 0x40000 if MACH_SUN8I_R528 || MACH_SUN50I_A133
>  	default 0x44000 if MACH_SUN55I_A523
> +	default 0x5A000 if MACH_SUN60I_A733
>  	default 0x54000 if MACH_SUN50I || MACH_SUN50I_H5
>  	default 0x18000 if MACH_SUN9I
>  	default 0x8000 if ARCH_SUNXI
> 


  reply	other threads:[~2026-01-02  0:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-30 21:45 [PATCH v2 00/10] sunxi: Add support for A733 SoC Yixun Lan
2025-11-30 21:45 ` [PATCH v2 01/10] sunxi: sun60i: initial " Yixun Lan
2026-01-02  0:40   ` Andre Przywara
2026-01-13  1:31     ` Yixun Lan
2025-11-30 21:45 ` [PATCH v2 02/10] sunxi: spl: a733: config text and stack address Yixun Lan
2026-01-02  0:40   ` Andre Przywara [this message]
2026-01-13  1:22     ` Yixun Lan
2025-11-30 21:45 ` [PATCH v2 03/10] sunxi: a733: uart: setup serial console Yixun Lan
2025-11-30 21:45 ` [PATCH v2 04/10] clock: a733: implement support for mmc/uart Yixun Lan
2025-11-30 21:45 ` [PATCH v2 05/10] clock: reset: a733: add initial support Yixun Lan
2025-11-30 21:45 ` [PATCH v2 06/10] gpio: " Yixun Lan
2025-11-30 22:09   ` Fabio Estevam
2025-11-30 22:20     ` Yixun Lan
2026-01-02  0:39       ` Andre Przywara
2025-12-01  0:01   ` Tom Rini
2025-12-01 10:37     ` Yixun Lan
2025-11-30 21:45 ` [PATCH v2 07/10] pinctrl: sunxi: " Yixun Lan
2025-11-30 21:45 ` [PATCH v2 08/10] pmu: axp318w: implement pmic/regulator support Yixun Lan
2026-01-02  0:40   ` Andre Przywara
2025-11-30 21:45 ` [PATCH v2 09/10] power: pmic: sunxi: add SPL support for the AXP318W Yixun Lan
2025-11-30 21:45 ` [PATCH v2 10/10] sunxi: mmc: enable support for A733 Yixun Lan
2026-01-02  0:41   ` Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260102014033.26410b4c@minigeek.lan \
    --to=andre.przywara@arm.com \
    --cc=contact@paulk.fr \
    --cc=dlan@gentoo.org \
    --cc=jagan@amarulasolutions.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=samuel@sholland.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox