Re: [PATCH v4 16/20] drm/mode-config: Create drm_mode_config_create_initial_state()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing `drm_connector_list_iter_end()` on the error path inside the connector iteration loop leaks a connector reference and an acquired lockdep context.
--

commit 1484ab42075b748d6480095cd1ab8eb591e8be02
Author: Maxime Ripard <mripard@kernel.org>

drm/mode-config: Create drm_mode_config_create_initial_state()

This commit splits the state initialization role from drm_mode_config_reset()
by introducing a new helper, drm_mode_config_create_initial_state(). This
helper allocates an initial software state for all objects, allowing
drm_mode_config_reset() to focus purely on suspend/resume cycles.

> diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
> index 9d240817f8b64..27fe951841824 100644
> --- a/drivers/gpu/drm/drm_mode_config.c
> +++ b/drivers/gpu/drm/drm_mode_config.c
[ ... ]
> @@ -316,6 +317,92 @@ void drm_mode_config_reset(struct drm_device *dev)
[ ... ]
> +int drm_mode_config_create_initial_state(struct drm_device *dev)
> +{
[ ... ]
> +	drm_connector_list_iter_begin(dev, &conn_iter);
> +	drm_for_each_connector_iter(connector, &conn_iter) {
> +		if (connector->state)
> +			continue;
> +
> +		ret = drm_mode_config_connector_create_state(connector);
> +		if (ret)
> +			return ret;

Does this return leak the connector reference and lockdep context?

Looking at drm_connector_list_iter_begin(), it acquires a lockdep read
context, and the iteration macro takes a reference to the connector. Should
this error path call drm_connector_list_iter_end(&conn_iter) before
returning to release them?

> +	}
> +	drm_connector_list_iter_end(&conn_iter);
> +
> +	return 0;
> +}
> +EXPORT_SYMBOL(drm_mode_config_create_initial_state);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512-drm-mode-config-init-v4-0-591dfdcc1bf9@kernel.org?part=16