Re: [PATCH v2 1/3] dt-bindings: iio: adc: Add GPADC for Allwinner A523

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Schema Conditional Logic Error: `if` block will silently fail to match A523 compatible string
--

commit f1e37c6efc76bc9bd352a9e8462984a80a03b87c
Author: Michal Piekos <michal.piekos@mmpsystems.pl>

dt-bindings: iio: adc: Add GPADC for Allwinner A523

This commit adds support for the GPADC on the Allwinner A523. It updates
the schema to allow two clocks for this new compatible string while
restricting previous generations to one clock.

> diff --git a/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml b/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml
> index da605a051b949..6467800d30e27 100644
> --- a/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml
[ ... ]
> @@ -40,6 +46,30 @@ properties:
>    resets:
>      maxItems: 1
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - allwinner,sun55i-a523-gpadc

Will this condition successfully match the A523 compatible string?

In dt-schema, the compatible property is parsed and evaluated as an array of
strings. By using enum directly without a contains: keyword, this condition
expects the property to be exactly a string.

Under JSON schema rules, this condition will evaluate to false because an
array cannot equal a string.

> +    then:
[ ... ]
> +    else:
> +      properties:
> +        clocks:
> +          maxItems: 1
> +        clock-names: false

Does this result in valid A523 device tree nodes being incorrectly rejected?

Since the if block silently fails to match, the schema will fall through to
this else block, enforcing maxItems: 1 for clocks and rejecting clock-names.
This would erroneously reject A523 configurations that correctly provide the
two required clocks.

Could the condition be updated to use contains: enum: or contains: const: to
properly match the compatible array elements?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-sunxi-a523-gpadc-v2-0-d5efde151dac@mmpsystems.pl?part=1