From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46503387361 for ; Wed, 15 Jul 2026 09:55:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109356; cv=none; b=O06dG9bFICnXk/h5w+9PLEaQDc5Di9wfE+AaGZIm9Uo6LQpctAADUlr7Y51GC1ei19x7/UbQuHUdvvKJ1WkTLVfhzGCiSZcnBoKo5U0Hwdu5eeQB3wuODXiT/Vd6gTEKQgEeKOXOYwntVp1iaT3XVzarKM0yxERXK4PRO8AYWX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109356; c=relaxed/simple; bh=k83hZbTKuOl//PgUx5fOIdMW+RR7uZ50uJTt+Avj9Nw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EsmV/S6pxLD9gW5cQyev6c0B5e6VGCUQpMV8lBiosEhu2qLAzwff1ktZQB6RD4gCEc5U2hDHWgdz5mA3VHr4PUkwkJ7dVSoAhVFFdrAy2uJprgVA1/IZkceYuf1Y9U5q/reAWjCVTOuYONil8gvST+fM3Bv6D3Kh9X+schSMjOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bHsrdTsB; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bHsrdTsB" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-ca913a601fbso3684642a12.3 for ; Wed, 15 Jul 2026 02:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784109355; x=1784714155; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7BpJzZu2JI6YrdHbblIuBNywzFxSYtVh1mg+KZtTDf0=; b=bHsrdTsBB71boIUssjlApZsWRRFgXrWVAaaguvRcpSIAm9NYjGq7PeScLu9Ndtg2Aw zfwma90KSvCJsc+w4rFMPsZmLNyBbYKWUkeP0ADePTR95z1LK21ODQpxM6/jemNhkpDB fDrETbqHb2CLLF3cSKMHmql6ntaOjniB9uQrx4CPLK3L6O1E8MH5nXApodjDV5/th502 uNcA4fMlau5alEvBlkgU8xnRBPycEZ7bTREKFwYhCUR8DcfqOCfyYSFmhsjzFk0IAKjM zpkN6/f9vVBSuMs+QFm3CHUMkar7Nlvb9+t2IjYX5rGi6su4LyLQhacsDCcXiu/alLUH /trg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784109355; x=1784714155; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=7BpJzZu2JI6YrdHbblIuBNywzFxSYtVh1mg+KZtTDf0=; b=dV9HG30b+4uDIW54yFLX2ncQ2cbCnhgTDSnZrHgs0GiFa9R7QIP4NR70VF1wN/fnxs r4UKkq5uswI60UwViLoRwIt8yP5cQVaTqDhwYxLr//4DIs9m79MXCiJFp9mRcAqwoPxi r74TLJ6khoJOXGX4gdm1jHAdIzaSFUJnEPOVz8ZHO8tOLDAcsHs/6ciDKxr3uvzcaovE rsIknOtFJks8kQ1Kqoh/k0qRmfnjgcCcAEoyuYoTSnJev+bsZx8EOnVL6i5wcSHJg9E4 uqadYWHSTJ+6sZlB4ZwyAJLzJMDEVksaZheYU2X6wRN3bBIF0fCw+/gDNNP/GGHyx2Ma EHRw== X-Forwarded-Encrypted: i=1; AHgh+Rp6NxdjsYpKVXq4SvV+XhPKq0+SEFsMQP1tVjRTKoyitkw6hJDlYBm/DVYO8IQwcBBRohLlRDxxPhBlyA==@lists.linux.dev X-Gm-Message-State: AOJu0Ywadr4me0WRYLGAJo/+OtOTgtaWO/Mg499sTve87y9A/5489wp8 mo7WgSUfhsc4fU0dTve0IO+tUJb3bQrKUvnT0+pwZYUhEAlZnwv3A9f2 X-Gm-Gg: AfdE7ckW80QdOmsFKnzA3+PZPfUy5/+388ksTDt9P0TRE7KQkhLvSRNizIHE1F7LrcK Ne9m2fWsmp4L9HJpEnbWDpGq7O5IhepmRuI8AzppOHfOBVH2Wl14YTvz6GUQc+YfF6jjrwxY74d q8/PeuAUCZF+sXLrhYmt/fpkKCnIARHsvlybg3lOKN7CfDonZwy09dfCpzH1akCPUO67CJd0ssB e5IZScG7LRcV5c/xgcgW1r0UabzO9Z89AgGhekI4KcfMmibwX+9kixfCkvl+6cMMvHWAyR+GLw9 e+kz86HuEADO8Pu8gSWkMGyPyZjxDOoo9VRGl1qu1VgU+bG1dqrTLU3KnWRKcuj49l0GbWeluk/ 61TYsxH5rzUsIWnYmmiSq4KS05U7vI6GfO637hK/sc161PLLgxD3FdBC7slANRjrNyL2zu8mgpx WiKYhQIP15dzdBx11QCK7APAslnYW+bPl1K8aBEa7Q8co09ww= X-Received: by 2002:a05:6a20:3d8b:b0:3b4:931c:3c7c with SMTP id adf61e73a8af0-3c357553dfcmr7448713637.44.1784109354620; Wed, 15 Jul 2026 02:55:54 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm11628908a12.22.2026.07.15.02.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 02:55:54 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai Cc: Jernej Skrabec , Samuel Holland , Charles Keepax , Kuninori Morimoto , Chen Ni , Marcus Cooper , Bjorn Helgaas , Danilo Krummrich , u.kleine-koenig@baylibre.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH 1/6] ASoC: sunxi: sun4i-codec: Use dev_err_probe() for probe error handling Date: Wed, 15 Jul 2026 16:55:20 +0700 Message-ID: <20260715095525.40668-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715095525.40668-1-phucduc.bui@gmail.com> References: <20260715095525.40668-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Use dev_err_probe() for probe error handling to simplify the error paths and handle -EPROBE_DEFER correctly. Signed-off-by: bui duc phuc --- sound/soc/sunxi/sun4i-codec.c | 70 ++++++++++++++--------------------- 1 file changed, 28 insertions(+), 42 deletions(-) diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c index f4e22af594fa..05308df3ae5b 100644 --- a/sound/soc/sunxi/sun4i-codec.c +++ b/sound/soc/sunxi/sun4i-codec.c @@ -2316,67 +2316,54 @@ static int sun4i_codec_probe(struct platform_device *pdev) scodec->regmap = devm_regmap_init_mmio(&pdev->dev, base, quirks->regmap_config); - if (IS_ERR(scodec->regmap)) { - dev_err(&pdev->dev, "Failed to create our regmap\n"); - return PTR_ERR(scodec->regmap); - } + if (IS_ERR(scodec->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->regmap), + "Failed to create our regmap\n"); /* Get the clocks from the DT */ scodec->clk_apb = devm_clk_get_enabled(&pdev->dev, "apb"); - if (IS_ERR(scodec->clk_apb)) { - dev_err(&pdev->dev, "Failed to get the APB clock\n"); - return PTR_ERR(scodec->clk_apb); - } + if (IS_ERR(scodec->clk_apb)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->clk_apb), + "Failed to get the APB clock\n"); scodec->clk_module = devm_clk_get(&pdev->dev, "codec"); - if (IS_ERR(scodec->clk_module)) { - dev_err(&pdev->dev, "Failed to get the module clock\n"); - return PTR_ERR(scodec->clk_module); - } + if (IS_ERR(scodec->clk_module)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->clk_module), + "Failed to get the module clock\n"); if (quirks->has_reset) { scodec->rst = devm_reset_control_get_exclusive_deasserted(&pdev->dev, NULL); - if (IS_ERR(scodec->rst)) { - dev_err(&pdev->dev, "Failed to get reset control\n"); - return PTR_ERR(scodec->rst); - } + if (IS_ERR(scodec->rst)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->rst), + "Failed to get reset control\n"); } scodec->gpio_pa = devm_gpiod_get_optional(&pdev->dev, "allwinner,pa", GPIOD_OUT_LOW); - if (IS_ERR(scodec->gpio_pa)) { - ret = PTR_ERR(scodec->gpio_pa); - dev_err_probe(&pdev->dev, ret, "Failed to get pa gpio\n"); - return ret; - } + if (IS_ERR(scodec->gpio_pa)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->gpio_pa), + "Failed to get pa gpio\n"); + scodec->gpio_hp = devm_gpiod_get_optional(&pdev->dev, "hp-det", GPIOD_IN); - if (IS_ERR(scodec->gpio_hp)) { - ret = PTR_ERR(scodec->gpio_hp); - dev_err_probe(&pdev->dev, ret, "Failed to get hp-det gpio\n"); - return ret; - } + if (IS_ERR(scodec->gpio_hp)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->gpio_hp), + "Failed to get hp-det gpio\n"); /* reg_field setup */ scodec->reg_adc_fifoc = devm_regmap_field_alloc(&pdev->dev, scodec->regmap, quirks->reg_adc_fifoc); - if (IS_ERR(scodec->reg_adc_fifoc)) { - ret = PTR_ERR(scodec->reg_adc_fifoc); - dev_err(&pdev->dev, "Failed to create regmap fields: %d\n", - ret); - return ret; - } + if (IS_ERR(scodec->reg_adc_fifoc)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->reg_adc_fifoc), + "Failed to create regmap fields\n"); scodec->reg_dac_fifoc = devm_regmap_field_alloc(&pdev->dev, scodec->regmap, quirks->reg_dac_fifoc); - if (IS_ERR(scodec->reg_dac_fifoc)) { - ret = PTR_ERR(scodec->reg_dac_fifoc); - dev_err(&pdev->dev, "Failed to create regmap fields: %d\n", - ret); - return ret; - } + if (IS_ERR(scodec->reg_dac_fifoc)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->reg_dac_fifoc), + "Failed to create regmap fields\n"); /* DMA configuration for TX FIFO */ scodec->playback_dma_data.addr = res->start + quirks->reg_dac_txdata; @@ -2422,10 +2409,9 @@ static int sun4i_codec_probe(struct platform_device *pdev) snd_soc_card_set_drvdata(card, scodec); ret = snd_soc_register_card(card); - if (ret) { - dev_err_probe(&pdev->dev, ret, "Failed to register our card\n"); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to register our card\n"); return 0; } -- 2.43.0