ARM Sunxi Platform Development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Andre Przywara" <andre.przywara@arm.com>
Cc: linux-sunxi@lists.linux.dev, conor+dt@kernel.org,
	devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH] arm64: dts: allwinner: a523: enable IR on the Avaota A1
Date: Wed, 22 Jul 2026 22:36:42 +0000	[thread overview]
Message-ID: <20260722223642.B2E951F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260722222627.14138-1-andre.przywara@arm.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Device tree compilation fails due to an unresolved reference to the `&ir` node label.
--

--- Patch [1]: [PATCH] arm64: dts: allwinner: a523: enable IR on the Avaota A1 ---
commit 357c50b8a0f2e8f0f484a1872fb40899f5baa624
Author: Andre Przywara <andre.przywara@arm.com>

arm64: dts: allwinner: a523: enable IR on the Avaota A1

This commit adds the IR receiver pin description to the PIO DT node
and enables the CIR receiver in the main power domain for the Avaota A1
board.

> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts b/arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts
> --- a/arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts

[ ... ]

> @@ -100,6 +100,12 @@ &gpu {
>  	status = "okay";
>  };
>  
> +&ir {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&ir_rx_pin>;
> +	status = "okay";
> +};
> +

[Severity: Low]
Does this node extension cause a build failure when compiling the device tree?

It looks like the &ir label is not defined in the base sun55i-a523.dtsi file
or any of its dependencies, which would cause dtc to fail with an unresolved
reference error. 

The commit message notes that this patch goes on top of another IR receiver
series. Should that base dependency be merged first to ensure the build
remains unbroken?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722222627.14138-1-andre.przywara@arm.com?part=1

      reply	other threads:[~2026-07-22 22:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 22:26 [PATCH] arm64: dts: allwinner: a523: enable IR on the Avaota A1 Andre Przywara
2026-07-22 22:36 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260722223642.B2E951F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=andre.przywara@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox