Re: [PATCH v10 2/2] mfd: ac200: Add X-Powers AC200 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Creating a local stack copy of the mfd_cell array for dynamic amendments violates MFD subsystem guidelines.
--

commit 89b84971b8215b5790b042d0288d352785ec348e
Author: James Hilliard <james.hilliard1@gmail.com>

mfd: ac200: Add X-Powers AC200 support

This patch adds support for the X-Powers AC200 mixed-signal companion IC. It
provides shared regmap access, an IRQ controller for the INTB output, and
instantiates the individual function devices like the audio codec and TV
encoder.

> diff --git a/drivers/mfd/ac200.c b/drivers/mfd/ac200.c
> new file mode 100644
> index 0000000000000..30828e113c11b
> --- /dev/null
> +++ b/drivers/mfd/ac200.c

[ ... ]

> +static int ac200_add_devices(struct device *dev)
> +{
> +	struct mfd_cell cells[ARRAY_SIZE(ac200_cells)];
> +	unsigned int num_cells = 0;
> +	unsigned int i;
> +	int ret;
> +
> +	for (i = 0; i < ARRAY_SIZE(ac200_cells); i++) {
> +		const struct mfd_cell *cell = &ac200_cells[i];
> +		struct device_node *child;
> +
> +		child = of_get_compatible_child(dev->of_node,
> +						cell->of_compatible);
> +		if (!child)
> +			continue;
> +		if (of_device_is_available(child))
> +			cells[num_cells++] = *cell;
> +		of_node_put(child);
> +	}
> +
> +	if (!num_cells)
> +		return 0;
> +
> +	ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_AUTO, cells, num_cells,
> +				   NULL, 0, NULL);

[Severity: Medium]
Does this pass a dynamically amended local stack copy of the mfd_cell array
to the MFD core?

The MFD subsystem guidelines advise against creating local copies of mfd_cell
arrays for dynamic amendments, as standard practice requires static const 
references for these arrays. 

Could this be updated so the static array is passed directly, leaving the
node availability checks to either the MFD core or the individual child
drivers during their own probe sequences?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260906-submit-ac200-mfd-v10-0-f522e8dc2bd4@gmail.com?part=2