From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CA2148821D for ; Tue, 29 Sep 2026 20:37:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790714244; cv=none; b=LaCRs8u22kLcutJg7G605pb2HApx5/IEAqs4g8eCAxN6zYm/Zbf3fSSHLSL/v4pRIbcxMog80krlOBhaCM7Wbz4DhOB+Mdus5P+RKVrYTLpWcAZnaN3yTDfaFIt3NARte6bYAJ7fGOH6SUXSdmjwX7U35cnZbbyiBPm/COFo5U0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790714244; c=relaxed/simple; bh=Gqvcy2MOOYrL8Gno0HNWN9hEb57iEhrmpV/Bp5STDho=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iNfvDnSv2pn+hI5Nmj+D9eDlHjUbct5sYDPtoid4DLRSzUO7VINFyjAUhcuNO2P8OYu6xN3DBG5yAj6XObyf5a8gBYbOO46g67EY+ZFvZ/VCKsnpr9NBtzXc0IoiH5iuW0qJKCR8/wetDvNuok/UP24FKlssLy5AiOAr1B/c+6Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dmYFsz9W; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dmYFsz9W" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-48434392b02so3987630f8f.3 for ; Tue, 29 Sep 2026 13:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790714241; x=1791319041; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=uc6m/QNpalNv4a9wmqg9O0BMMr47ojwjmucGyrpTpAA=; b=dmYFsz9W5gkd5g00STEtVFF2TCYtu+zOZxdlKAhDG0Y5JP+yqPM2uHFrqn8DEjErtR nxPbA1GORA3BxJe2nkyofrwXmB6rRA961Qdf62jGwTUjtMwmfidyHa8/grQjoTYkT5gq w66ePRg3Vfr6SuBMTJb+7dJP9bFrIxcsCv/UeVIVivOdi+JvzF2453AMyX0IXmJCjad5 BQBAcNO+WG2JdRcWB2gwYKnLGY7DY+dXhmkNsfS4rOVPefTzzGnhfFKioYOkjZkqdM7X Cb1b7JfG9vwrAH+ICUtFVdkB32deMtBDgM9aqLPW+CZTfNDac1vRVWPmuzvmL+ayc0k3 nVNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790714241; x=1791319041; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uc6m/QNpalNv4a9wmqg9O0BMMr47ojwjmucGyrpTpAA=; b=a3TsS0/bwt82QqyaKU7TfszxBqctmdYy1rOTHGyIcaLW4X5ppWuADqOc3VNFQ0uDw0 o6rQy6M/nKFxlSIInqJSZGO6WQa3kEsIJ2a+8bUpp5bil3mF6io9IhCLeiXvNsxT66GQ SpZVNB2updzzMrl9/d7RjLTPd43DlwW+kBol6e50MXZPdwz4Wry5JxwkQ+3X5R0htTN3 3T519ErTIDzgJqzM8EHGwcDYsLsR7dEefSwm742WOhS566PeSEUJnYhlHJ5MDk4ecODo If7QUYVCoHwIRvNhgAwmAIKxNznE2WVvZ1Y15mQ17k+JHtL7BQVytNRHQ1GJg6nU133H vu2w== X-Forwarded-Encrypted: i=1; AKwUvByBicTTDaK74p14YzuNVH2eL+30udnzZw2fRgTAjY2iN73+fQyl04IQN6iCEqgETG9OVK50lD4xMREPHg==@lists.linux.dev X-Gm-Message-State: AFq9FYJVAHNSm9BazaZnfrYRNgjsFZ4jiX+SIlkBBL68kJxhGXfslou2 WsS96Ff7uS4aJCZfbMFuadH/ZtTrSItEujj+xEVjTekveLkSu3Ubh3pu X-Gm-Gg: AYBFou1dB8gCioBCX7bUIK+uvmbnDvgT750UV1qXAIOXwb/cludG2b7S5OFFZABEVUp xjj9qJNCLqil6yfBRJjqLo0fw5qW7WjUSOddxLViiiuTptqEC5pfeRxnxZgLCgglR5vtk8Xzuke zJQ/Nr9r7OESiE6F0CfQkC8YOnyFHh6Ps62LOvRGXlySCrD8aFg+B3rSnBY90zeAQufRFghNL5O t62Pv/sFYq0XO8T73cGg+Mgiee4kGelmnYj0Sr8W//Lr619/a9jkJpPlfjoRDntXME0xe6bDZip bSdR2g/mX4iov7pz4507m2UrIizDmWRa3QoqDF4hh2Fl10Vw2c3ZZKmmQ75cyvE5CxNRwppT3+q M8gzDbAXR5kj5an0fPda8bCbKrjL7cQEtEwNWMTNV7QKb4oyhzVncrNrXx9MnhnI0nZQt5PZTer REUilvvLP9xEMKJzBnSDUp0/sLu30ZCXid53o56pUD0WSoTwhxH/jd5jS991f21zswJlOvLxpSm GSv9Jfu3lDPI49RZPW5DXNMNumWbc9j6SrPNB9drskl X-Received: by 2002:a05:6000:381:b0:487:27f9:83d with SMTP id ffacd0b85a97d-48afe782c3amr766701f8f.50.1790714241257; Tue, 29 Sep 2026 13:37:21 -0700 (PDT) Received: from debian (ip-78-137-176-146.broadband.digiweb.ie. [78.137.176.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48afe6a9624sm1237578f8f.24.2026.09.29.13.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2026 13:37:20 -0700 (PDT) From: Pablo Mazzini To: Linus Walleij , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andre Przywara Cc: Pablo Mazzini , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: sunxi: dt: number the IRQ banks from the first one that has IRQs Date: Tue, 29 Sep 2026 21:36:34 +0100 Message-ID: <20260929203634.32998-1-pmazzini@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit prepare_function_table() assumes the first pin is in bank 0. On the A523, which has no PA pins, every IRQ bank is numbered one too high: the last bank writes past the end of irq_array, and interrupts are looked up at the wrong offsets. Count the IRQ banks from the first bank that has interrupts. Fixes: f5e2cd34b12f ("pinctrl: sunxi: allow reading mux values from DT") Signed-off-by: Pablo Mazzini --- drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c b/drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c index 50a16f3bd131..9c5eb21a86a5 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c @@ -208,7 +208,7 @@ static int prepare_function_table(struct device *dev, struct device_node *pnode, * The extra functions will be filled in later. */ irq_bank = 0; - last_bank = 0; + last_bank = -1; for (i = 0; i < npins; i++) { struct sunxi_desc_pin *pin = &pins[i]; int bank = (pin->pin.number - pin_base) / PINS_PER_BANK; @@ -221,16 +221,14 @@ static int prepare_function_table(struct device *dev, struct device_node *pnode, func[1].muxval = 1; if (irq_mux) { - if (bank > last_bank) + if (last_bank >= 0 && bank > last_bank) irq_bank++; func[lastfunc].muxval = irq_mux; func[lastfunc].irqbank = irq_bank; func[lastfunc].irqnum = pin->pin.number % PINS_PER_BANK; func[lastfunc].name = "irq"; - } - - if (bank > last_bank) last_bank = bank; + } pin->functions = func; -- 2.53.0