From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.siol.net (mailoutvs39.siol.net [185.57.226.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2246672 for ; Sun, 11 Apr 2021 18:18:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id E0BF9525531; Sun, 11 Apr 2021 20:18:42 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta09.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta09.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id eZShPbwdXxkD; Sun, 11 Apr 2021 20:18:42 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id A100952552D; Sun, 11 Apr 2021 20:18:42 +0200 (CEST) Received: from kista.localnet (cpe-86-58-17-133.cable.triera.net [86.58.17.133]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id F1B3B525539; Sun, 11 Apr 2021 20:18:41 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: lujialin4@huawei.com, Mauro Carvalho Chehab , Maxime Ripard , Chen-Yu Tsai , Philipp Zabel , Lu Jialin Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] media: sun8i: Fix PM reference leak in deinterlace_start_streaming() Date: Sun, 11 Apr 2021 20:18:41 +0200 Message-ID: <2184866.DZomrXFPLt@kista> In-Reply-To: <20210408133630.56299-1-lujialin4@huawei.com> References: <20210408133630.56299-1-lujialin4@huawei.com> X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne =C4=8Detrtek, 08. april 2021 ob 15:36:30 CEST je Lu Jialin napisal(a): >=20 > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. >=20 > Reported-by: Hulk Robot > Signed-off-by: Lu Jialin Acked-by: Jernej Skrabec Best regards, Jernej