From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3C89148FF6 for ; Fri, 26 Apr 2024 16:07:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714147668; cv=none; b=uiRwuvchAX/YVa2NYjuvowfyI/QU1R09xgzirpzLO/gVn5l9S0dUoyuEeUAbbinnqOj8Q/JZyyJNN6tKhnPB1LJTJSmBCvjNyjR+cQtCokIDMG6xLXbrLzt8nU+00H4GrR4jYXWhj21OsddrdfYrCDQ/3uUO5DgG6sXkw/xYbsE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714147668; c=relaxed/simple; bh=Ov5uUPnrz3wAws4wWrFyH7JPRH8FOtLsH3Miyh1IPmw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ErpZjbyF01bDtboK0ctRBnpbMbCLUfbawGN8mAzhxa584vSK1xl4Yxl+rdXSCzQELI+LxAKr/G5NNs6iPhN2eOKEKRs9CZ0maDi9lUVRpMiC7KxhetVWjiFbsQE6/S0bUHHBqhJX6iQ+nmYWnS3yOa8WsVZnjBPIB+YBhGqzypE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SD57lwnK; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SD57lwnK" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-34782453ffdso2164190f8f.1 for ; Fri, 26 Apr 2024 09:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714147664; x=1714752464; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e98uEa894yCRMEcpOdy/aYqOMPHaErz9efzMY9n7gOU=; b=SD57lwnKFAVZpfYIo/Vd74fngeZsUD2na/196XHfapmx0WfE2/XXixJDMeHUaoQa9i DXyWZsU9DBjO5fhzLDdKTe1WqX3iBnO4FP0EFLgEkb++dA41Ny6NjofXYvcRJmZ/UvGf VeP/dl/RWT4zR1lUD2+RZ4doPIrTTtfOhAYZxq1fIUE91v5yf6LLUmbvgr7L4byEUxIv jm7AH4oVkqiIf9lGEWGcP9Ky5kMVkUvCIaOPwvIMQDjRYOx97bwB2a/cqX8pJIGQ4Lam 6x9pNlQ4dbQe+JW2Lb8oO/gWwgLHdfzpcPpKlkC2qu9U2Rh7co/MYN9Gs6217v5y+2aO TDRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714147664; x=1714752464; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e98uEa894yCRMEcpOdy/aYqOMPHaErz9efzMY9n7gOU=; b=r12nnyuuZndssZNyMQy3gxU5+WRW6E6IEj77ya3VKn2QyKeP9AqCmO7c8bwQ7rJ2yh oAO5edv2sfFjA981BWZapLnw3pz6xBfjpZtMpARt0J1ddgGkBAH4dc9KDbm33U5iejOc HSZla5p5h8a9E3dqbBNEydmN6Zj0g0CwexC5VTrcC1EskoG5mxu8l4vRZwEhQCN8R2JB cwAEoo8luw7pUe8mTrygpzRvv3Vhiqs3xhCrxQB/5em3MOCbpeLAW4N9CDFoaQPUgWWN JQUjzbIFeJ28613FtBSZJoRCieX/I5LCNS4Q5f7GnV2bjZXUqQy7VGxXhMwHLYwJA/JM 9jXQ== X-Forwarded-Encrypted: i=1; AJvYcCWqrujnwesxLg4VyZJXLQkiv5gWyV7weHZD6fIS4Q0Lh2w1jPZj+EVi5DhrwjCVb+Kq7/qjELFM9KY+dGN3efMfnI1VxeEJF8Cee5o= X-Gm-Message-State: AOJu0Yx51h4dtxNHLZ14lCrKdetpgPX+WPuoIMCI4XjzxVyGrdPXARj4 5EvJgpvLNWE3MrLzAWwPa0I/eneONRQcMe7BeVqkGRDOjp0yL0ZU X-Google-Smtp-Source: AGHT+IFPsYon1jXLWFTL68+Mkma0tqyi5dVEaECddz1D4hvd9+t9cZxPgeJo7xRi8H9x71Ea+jLy9A== X-Received: by 2002:adf:fecf:0:b0:343:734e:73d1 with SMTP id q15-20020adffecf000000b00343734e73d1mr2440243wrs.37.1714147664042; Fri, 26 Apr 2024 09:07:44 -0700 (PDT) Received: from jernej-laptop.localnet (86-58-6-171.dynamic.telemach.net. [86.58.6.171]) by smtp.gmail.com with ESMTPSA id c11-20020adffb0b000000b0034b1a91be72sm10834913wrr.14.2024.04.26.09.07.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 09:07:43 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Andre Przywara , Chen-Yu Tsai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Samuel Holland , Chris Morgan , Ryan Walklin Cc: devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev, Ryan Walklin Subject: Re: [PATCH v4 4/4] arm64: dts: allwinner: h700: Add RG35XX-H DTS Date: Fri, 26 Apr 2024 18:07:42 +0200 Message-ID: <2187659.Mh6RI2rZIc@jernej-laptop> In-Reply-To: <20240426095141.13602-6-ryan@testtoast.com> References: <20240426095141.13602-2-ryan@testtoast.com> <20240426095141.13602-6-ryan@testtoast.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Dne petek, 26. april 2024 ob 11:51:42 GMT +2 je Ryan Walklin napisal(a): > The RG35XX-H adds thumbsticks, a stereo speaker, and a second USB port to the RG35XX-Plus, and has a horizontal form factor. > > Enabled in this DTS: > - Thumbsticks > - Second USB port > > Signed-off-by: Ryan Walklin > Reviewed-by: Andre Przywara > --- > Changelog v1..v2: > - Update copyright > - Spaces -> Tabs > - Add GP ADC joystick axes and mux [1] > - Add EHCI/OHCI1 for second USB port and add vbus supply > > Changelog v2..v3: > - Add DTB to Makefile > - Remove USB vbus supply > - Remove GPADC joysticks until required patches land [1] > - Move thumbsticks into existing gpio gamepad node > - Move changelog and links below fold-line > > Changelog v3..v4: > - Remove redundant USB OTG and PHY nodes. > > [1]: https://lore.kernel.org/linux-sunxi/20240417170423.20640-1-macroalpha82@gmail.com/T/#t > > Signed-off-by: Ryan Walklin > --- > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../sun50i-h700-anbernic-rg35xx-h.dts | 37 +++++++++++++++++++ > 2 files changed, 38 insertions(+) > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-h.dts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > index 4217328b1889..c2c871d8b71e 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -49,3 +49,4 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-orangepi-zero3.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-transpeed-8k618-t.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-2024.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-plus.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-h.dtb > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-h.dts b/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-h.dts > new file mode 100644 > index 000000000000..fd581360e987 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-h.dts > @@ -0,0 +1,37 @@ > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +/* > + * Copyright (C) 2024 Ryan Walklin . > + * Copyright (C) 2024 Chris Morgan . > + */ > + > +#include "sun50i-h700-anbernic-rg35xx-plus.dts" > + > +/ { > + model = "Anbernic RG35XX H"; > + compatible = "anbernic,rg35xx-h", "allwinner,sun50i-h700"; > +}; > + > +&gpio_keys_gamepad { > + Remove empty line. With that: Reviewed-by: Jernej Skrabec Best regards, Jernej > + button-thumbl { > + label = "GPIO Thumb Left"; > + gpios = <&pio 4 8 GPIO_ACTIVE_LOW>; /* PE8 */ > + linux,input-type = ; > + linux,code = ; > + }; > + > + button-thumbr { > + label = "GPIO Thumb Right"; > + gpios = <&pio 4 9 GPIO_ACTIVE_LOW>; /* PE9 */ > + linux,input-type = ; > + linux,code = ; > + }; > +}; > + > +&ehci1 { > + status = "okay"; > +}; > + > +&ohci1 { > + status = "okay"; > +}; >