From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2903B3D541 for ; Tue, 9 Jan 2024 20:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YmM9CEOe" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3374c693f92so2757013f8f.1 for ; Tue, 09 Jan 2024 12:15:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704831309; x=1705436109; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M+B0yD7FjBgqTqLo7b2/IVuy2rnma81MvruhVPGvifo=; b=YmM9CEOePdiLPEonyfLkjYpdQZa5l1suGPR4LsrnnvvFEz6uikXJvxF0LnuOr7rp89 qsd0j69QOW3y8DpXHLFN8U42uuvcYFc9WDEJQUaUKKFdJbw4RVUJXa65C+tKVsYZgAVG GG0l6evtcEzBO+0vgaWbEpyoVmRQIB8B6x2Odl0ZKW+0hHJXibemU2yd2M+4tGGuOLYr YWbx9MwzEAkRMH6rnK91Y6mSDOJxZcKrmlLskNPYPbZFlDrl3hbWzW4RhZh/FoKcIINZ jwXmS7yDnbYOjtD7XVVIpBe+yQoGUYuiq3HQWcUKaerJeHLdxf1YpjOSnPc6Oc8NlOk1 Q4qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704831309; x=1705436109; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M+B0yD7FjBgqTqLo7b2/IVuy2rnma81MvruhVPGvifo=; b=mENEopDw4+wvt/1vnub4Vj0XEwD+negOVu0YLvS9+qGDBjn0nYq5apH76mc7Il7a/R v1ylhalRExRK7MXM4Q5JL3gnKKCbbwhDT7buCB7KUMKfcwequqThPESqqOA5Sp86KquS 3rpHzYASgdXKlR0+QVgU7oEdRb57XlRuuH+pPNsdjjI9nt4J0PnuMFXkv6WIK5SMteGF Kvsff+10ladB2FrqeZiglE8qJsLvVa3YRA5IaSrnMygvQzWFZX5da1h8uCu3dinDaDgQ 9sdcncSqOAsopO7Un6aV5P5OvnOgsmwyVSoIGYsAQRnsTYnbMJbxAOwFIxgkjBRcycxr J7Jg== X-Gm-Message-State: AOJu0YwtVK7vy3hOPtkMB972ZGKY/QTMLcuK8Meo6MARFV236s5i+MMc yYuj6phxU+w3cOz2oYoyLM0= X-Google-Smtp-Source: AGHT+IHCUv6AIBjSaTr/8HPaqeDyMqGvcLyT6MaYhYhF7PYV0/3Jv2044yKOg30ZXyxDXKOcj8h8FQ== X-Received: by 2002:a5d:5406:0:b0:336:5b14:525f with SMTP id g6-20020a5d5406000000b003365b14525fmr1021417wrv.132.1704831309212; Tue, 09 Jan 2024 12:15:09 -0800 (PST) Received: from jernej-laptop.localnet (213-161-3-116.dynamic.telemach.net. [213.161.3.116]) by smtp.gmail.com with ESMTPSA id cg4-20020a5d5cc4000000b003377c5b8a43sm45539wrb.93.2024.01.09.12.15.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 12:15:08 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: fuyao , Jakub Kicinski Cc: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Chen-Yu Tsai , Samuel Holland , Maxime Coquelin , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, =?utf-8?B?6bqm5YGl5bu6?= Subject: Re: [PATCH] gmac: sun8i: r40: add gmac tx_delay support Date: Tue, 09 Jan 2024 21:15:07 +0100 Message-ID: <22143664.EfDdHjke4D@jernej-laptop> In-Reply-To: <20240102075807.1a4cac92@kernel.org> References: <20240102075807.1a4cac92@kernel.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Dne torek, 02. januar 2024 ob 16:58:07 CET je Jakub Kicinski napisal(a): > On Thu, 21 Dec 2023 15:16:54 +0800 fuyao wrote: > > I don't see it in the user manual also. > > > > it works fine in 100M, but it doesn't work good in 1G without tx_delay > > in my board. > > > > Read the sdk from allwinner I found in: > > > > https://sourcegraph.com/github.com/tinalinux/linux-3.10/-/blob/arch/arm/boot/dts/sun8iw11p1.dtsi?L1826 > > https://sourcegraph.com/github.com/tinalinux/linux-3.10@r40-v1.y/-/blob/drivers/net/ethernet/allwinner/sunxi-gmac.c?L877 > > > > And I add it to my board, it works fine. > > > > So, I think it may be exist register but not documented. > > Unless Allwinner can chime in we should at least document the situation > clearly in the commit message (incl. what HW+config was tested, exactly) > and add a comment in the code? > I agree. Fuyao, please do that. Best regards, Jernej