Re: [PATCH] Fix detection of odd memory configurations on sunxi

["Jernej Škrabec" <jernej.skrabec@gmail.com>]

Dne sobota, 16. avgust 2025 ob 14:18:44 Srednjeevropski poletni čas je Rudi Horn napisal(a):
> Hi Jernej,
> 
> thanks for the comments on the patch.
> 
>  > I don't see a benefit for public function here, since it's unlikely 
> to be > used anywhere else. Just mark it static. Compiler can optimize 
> it better.
> 
> My motivation for this was that the implementation relies on subtracting
> `sizeof(u32)` from the address. This is an implementation detail that relies
> on the internals of `mctl_mem_matches_base`, and so I wanted to place
> it in the same file as `mctl_mem_matches_base`, preventing it from being
> static. It will only be called twice, so I don't think optimization is 
> too much
> of an issue. However I don't feel strongly on this if you would still prefer
> it in the same file.
> 
> Once this is resolved, I will submit another patch with all of the other
> comments addressed.

Ah, right. You can leave as it is.

Best regards,
Jernej

> 
> Thanks,
> Rudi
> 
>