From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E22FB7C for ; Mon, 14 Feb 2022 11:35:26 +0000 (UTC) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJZ4E-00080o-TO; Mon, 14 Feb 2022 11:58:50 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Thierry Reding , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= , Lee Jones , Rob Herring , Krzysztof Kozlowski , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Palmer Dabbelt , Paul Walmsley , Nobuhiro Iwamatsu , Philipp Zabel , Anson Huang , Vijayakannan Ayyathurai , Rahul Tanwar , Jeff LaBundy , Yash Shah , Sagar Kadam , Vignesh R , Yoshihiro Shimoda , Laurent Pinchart , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Krzysztof Kozlowski Subject: Re: [PATCH 06/15] dt-bindings: pwm: rockchip: include generic pwm schema Date: Mon, 14 Feb 2022 11:58:49 +0100 Message-ID: <2270696.mDkAqzPR1c@diego> In-Reply-To: <20220214081605.161394-6-krzysztof.kozlowski@canonical.com> References: <20220214081605.161394-1-krzysztof.kozlowski@canonical.com> <20220214081605.161394-6-krzysztof.kozlowski@canonical.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Montag, 14. Februar 2022, 09:15:56 CET schrieb Krzysztof Kozlowski: > Include generic pwm.yaml schema, which enforces PWM node naming and > brings pwm-cells requirement. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Heiko Stuebner > --- > .../devicetree/bindings/pwm/pwm-rockchip.yaml | 74 ++++++++++--------- > 1 file changed, 38 insertions(+), 36 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml > index 81a54a4e8e3e..a336ff9364a9 100644 > --- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml > +++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml > @@ -51,42 +51,44 @@ properties: > required: > - compatible > - reg > - - "#pwm-cells" > - > -if: > - properties: > - compatible: > - contains: > - enum: > - - rockchip,rk3328-pwm > - - rockchip,rv1108-pwm > - > -then: > - properties: > - clocks: > - items: > - - description: Used to derive the functional clock for the device. > - - description: Used as the APB bus clock. > - > - clock-names: > - items: > - - const: pwm > - - const: pclk > - > - required: > - - clocks > - - clock-names > - > -else: > - properties: > - clocks: > - maxItems: 1 > - description: > - Used both to derive the functional clock > - for the device and as the bus clock. > - > - required: > - - clocks > + > +allOf: > + - $ref: pwm.yaml# > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - rockchip,rk3328-pwm > + - rockchip,rv1108-pwm > + > + then: > + properties: > + clocks: > + items: > + - description: Used to derive the functional clock for the device. > + - description: Used as the APB bus clock. > + > + clock-names: > + items: > + - const: pwm > + - const: pclk > + > + required: > + - clocks > + - clock-names > + > + else: > + properties: > + clocks: > + maxItems: 1 > + description: > + Used both to derive the functional clock > + for the device and as the bus clock. > + > + required: > + - clocks > > additionalProperties: false > >