From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE8767A for ; Tue, 15 Mar 2022 19:22:54 +0000 (UTC) Received: by mail-ej1-f44.google.com with SMTP id dr20so42380928ejc.6 for ; Tue, 15 Mar 2022 12:22:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YUZLGSm75zNh7rcYmCCbe97E+affE9AzchNO0OWxx4o=; b=cCFx+shCgIVka6s5fOiT+wREmOnQNIvnqKe3Op2trhAh9UheCWIrFXkW+s4OGLFZg8 3f/hmiwIx6xETfTpBaDhyvsp5e+la/BaRAVUo2Hkn6VhJXBpNLUZ/CebWTe5+I+2TArn ZoBmhqvS42Fi+0U9YGhV3OF6TPzuxEBnrZBiIsOD4DMGpr5lWzbl78BTF0XGGGVBuHvd Nfw9hlez1k1oCKSRv2Y4mmiL6RFdUgYbaZvJjwxwucRWtjNXJqOEnjyewIILyqKQzY8A ptO4vaPR/B9wl75cLXCpPreHkpJaVDgWAjbySHrWO/oP3/F6vfvVFzIh7iUTLmAPk1c+ VoSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YUZLGSm75zNh7rcYmCCbe97E+affE9AzchNO0OWxx4o=; b=xfcpsf3HaP4qbJvFLHss/RFjmLLmxHidvkWLY8rRriQwz0GNcSK86nvTILw9tj/+dg FuDkE+I59eVAJVgLXly3d3ahp6fd3w4QYM6zAjkAL3moM77AnXrqlW4XeHqovYFZxe7i ppRi5hGSpGlnaqhvulI1YIJnYYtLeFmi/999i9HSy2/BRhiYfslNPndtPYILeGlNy+L7 bnkCjjvb7DVm2ST9MKcOtDKYJm5cBm8JL7GrLcVlHnVcKChJP2vXZXo7GAQs4AaaFIKB rom4lRHxbzpOhHUpj4UbNcgaxhbRK6ZEX6958jElnIMZFLrv3DGAoxt8oXq+blTK9Qj+ DFNw== X-Gm-Message-State: AOAM531RZLbsYTNMOJSCMyqkcQQT4gcnzGxQhjL6GgpBNkgFzhNR8gzQ NmjrmSSKmXqJvmu8Jw/Iwn0= X-Google-Smtp-Source: ABdhPJx3oMQvDZcegvWM9E7xJZyXa9HzvY7rQWf3ct9h7oMvijJQwqMRKb2G2l22n3jGgUQYENCK5Q== X-Received: by 2002:a17:906:52c7:b0:6ce:a880:50a3 with SMTP id w7-20020a17090652c700b006cea88050a3mr23528658ejn.437.1647372172743; Tue, 15 Mar 2022 12:22:52 -0700 (PDT) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id n4-20020a056402060400b00415a1f9a4dasm9918377edv.91.2022.03.15.12.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 12:22:52 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Paul Kocialkowski Cc: Yong Deng , Paul Kocialkowski , Mauro Carvalho Chehab , Chen-Yu Tsai , Samuel Holland , Laurent Pinchart , Maxime Ripard , Thomas Petazzoni Subject: Re: [PATCH v3 03/46] media: sun6i-csi: Grab bus clock instead of passing it to regmap Date: Tue, 15 Mar 2022 20:22:50 +0100 Message-ID: <2361247.jE0xQCEvom@kista> In-Reply-To: <20220311143532.265091-4-paul.kocialkowski@bootlin.com> References: <20220311143532.265091-1-paul.kocialkowski@bootlin.com> <20220311143532.265091-4-paul.kocialkowski@bootlin.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Paul! Dne petek, 11. marec 2022 ob 15:34:49 CET je Paul Kocialkowski napisal(a): > Since the bus clock alone is not enough to get access to the registers, > don't pass it to regmap and manage it instead just like the other > clocks. > Let me ask it in another way, is bus clock needed only for register access? If yes, it makes sense to keep it enabled only during register access. Best regards, Jernej > Signed-off-by: Paul Kocialkowski > --- > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 10 ++++++++-- > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h | 1 + > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c b/drivers/ media/platform/sunxi/sun6i-csi/sun6i_csi.c > index 5fbaa1e99412..dc79f3c14336 100644 > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > @@ -827,13 +827,19 @@ static int sun6i_csi_resource_request(struct sun6i_csi_device *csi_dev, > if (IS_ERR(io_base)) > return PTR_ERR(io_base); > > - csi_dev->regmap = devm_regmap_init_mmio_clk(&pdev->dev, "bus", io_base, > - &sun6i_csi_regmap_config); > + csi_dev->regmap = devm_regmap_init_mmio(&pdev->dev, io_base, > + &sun6i_csi_regmap_config); > if (IS_ERR(csi_dev->regmap)) { > dev_err(&pdev->dev, "Failed to init register map\n"); > return PTR_ERR(csi_dev->regmap); > } > > + csi_dev->clk_bus = devm_clk_get(&pdev->dev, "bus"); > + if (IS_ERR(csi_dev->clk_bus)) { > + dev_err(&pdev->dev, "Unable to acquire bus clock\n"); > + return PTR_ERR(csi_dev->clk_bus); > + } > + > csi_dev->clk_mod = devm_clk_get(&pdev->dev, "mod"); > if (IS_ERR(csi_dev->clk_mod)) { > dev_err(&pdev->dev, "Unable to acquire csi clock\n"); > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h b/drivers/ media/platform/sunxi/sun6i-csi/sun6i_csi.h > index e4e7ac6c869f..356661b413f8 100644 > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h > @@ -51,6 +51,7 @@ struct sun6i_csi_device { > struct sun6i_video video; > > struct regmap *regmap; > + struct clk *clk_bus; > struct clk *clk_mod; > struct clk *clk_ram; > struct reset_control *reset; > -- > 2.35.1 > >