From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F14751C04 for ; Mon, 15 Aug 2022 14:00:18 +0000 (UTC) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oNadS-00041B-2k; Mon, 15 Aug 2022 16:00:06 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Chen-Yu Tsai , Jernej Skrabec , linux-arm-kernel@lists.infradead.org Cc: Samuel Holland , Arnd Bergmann , Hans de Goede , Icenowy Zheng , Krzysztof Kozlowski , Maxime Ripard , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Samuel Holland Subject: Re: [PATCH v2 04/10] soc: sunxi: sram: Prevent the driver from being unbound Date: Mon, 15 Aug 2022 16:00:05 +0200 Message-ID: <2458395.Sgy9Pd6rRy@diego> In-Reply-To: <20220815041248.53268-5-samuel@sholland.org> References: <20220815041248.53268-1-samuel@sholland.org> <20220815041248.53268-5-samuel@sholland.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Montag, 15. August 2022, 06:12:41 CEST schrieb Samuel Holland: > This driver exports a regmap tied to the platform device (as opposed to > a syscon, which exports a regmap tied to the OF node). Because of this, > the driver can never be unbound, as that would destroy the regmap. Use > builtin_platform_driver_probe() to enforce this limitation. > > Fixes: 5828729bebbb ("soc: sunxi: export a regmap for EMAC clock reg on A64") > Reviewed-by: Jernej Skrabec > Signed-off-by: Samuel Holland Reviewed-by: Heiko Stuebner Tested-by: Heiko Stuebner