From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 285006129 for ; Wed, 12 Oct 2022 22:04:07 +0000 (UTC) Received: by mail-ej1-f50.google.com with SMTP id y14so93661ejd.9 for ; Wed, 12 Oct 2022 15:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=05/YOF9lKengUXPyv4GjbMJL03h9GoaGK9qputQVcKQ=; b=pSZ1sMPUODSiAfjgbX18qE71vIigyta7liB/jyM3MF3Ewq6S/sCW92zPFD9qlmLzx5 RK/dU+TwB7ooNVLGLVNwoVmYcgBfmRvMtpN1gv4KVeaIRSE4fs4QR4C0Ukve+vkbfR4d DRJ/4RkQvdtl6jqTe3on/a9T8c8MIgo3r/tDHmvu9GONEnWzeyHfN0xPBEu8voM8SPgy +EqCG0kB0YMj37kW6tlQimAm1DaasJ89y/wE46w6sfFAl7R1HxSeyltZ4SAXYshTR5db DpRd05DA6mZGdJUU++o0BF4d9HxIgii260GjcVXYRW9RrO2s+Yk+HNPmpiJGefWuiQ43 Jfww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=05/YOF9lKengUXPyv4GjbMJL03h9GoaGK9qputQVcKQ=; b=xfVC7BpnEt/FfLSqHgNK45goDLsX5Nqyn322W7yhD6N47A1lQS/YEgRRG5bb0ud2HH x/vrIaAf4v9JhrgJGVmBA+gMsCS+9WL5e53XTaLqroVZuUDy4kaOpQ7ydzXL2u+oatu7 nbCHoQpXk6+0VJYw+sxNq/5d8KRvwY9q+3TOsAP6/m93XSuKs0N/ICTvbPybbksALB2a D4LdR3FWTcGoQF4FDCguRen0J19Q+0dYm3jlf53YURV3tpVbR4FfAsfkBjscUUOqOp4g QixyUFChg67pau78JuPBF6yBp/Qnpz79oj1ctleOp2O83PD7ui1N3YXYw8AhxWXojPHx e5zw== X-Gm-Message-State: ACrzQf3+ZHudtBws056dabqi0d01dIV8XCWbl2UZ5PTcGUn1BYdDEIA9 ysNxJOTOyaDG/VZIw3wiyZ0= X-Google-Smtp-Source: AMsMyM7H5BDzL7/Y47HYKrpQ9t0CHdfgPAcDBA0E2sccNKcx67HoTE4AqTsjnHFp8sFb7pAx0Z+6lQ== X-Received: by 2002:a17:907:3181:b0:787:d81c:a6ad with SMTP id xe1-20020a170907318100b00787d81ca6admr23629517ejb.769.1665612245437; Wed, 12 Oct 2022 15:04:05 -0700 (PDT) Received: from kista.localnet (82-149-19-102.dynamic.telemach.net. [82.149.19.102]) by smtp.gmail.com with ESMTPSA id g1-20020a17090604c100b00731803d4d04sm1870324eja.82.2022.10.12.15.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 15:04:04 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: yong.deng@magewell.com, Yang Li Cc: mchehab@kernel.org, wens@csie.org, samuel@sholland.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: Re: [PATCH -next] media: sun6i-csi: Remove unnecessary print function dev_err() Date: Thu, 13 Oct 2022 00:04:03 +0200 Message-ID: <2603792.X9hSmTKtgW@kista> In-Reply-To: <20220929054003.37487-1-yang.lee@linux.alibaba.com> References: <20220929054003.37487-1-yang.lee@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Hi Yang, Dne =C4=8Detrtek, 29. september 2022 ob 07:40:03 CEST je Yang Li napisal(a): > The print function dev_err() is redundant because platform_get_irq() > already prints an error. >=20 > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D2314 > Reported-by: Abaci Robot > Signed-off-by: Yang Li Acked-by: Jernej Skrabec Best regards, Jernej > --- > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c index > 8b99c17e8403..9119f5e0e05e 100644 > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > @@ -913,7 +913,6 @@ static int sun6i_csi_resources_setup(struct > sun6i_csi_device *csi_dev, >=20 > irq =3D platform_get_irq(platform_dev, 0); > if (irq < 0) { > - dev_err(dev, "failed to get interrupt\n"); > ret =3D -ENXIO; > goto error_clock_rate_exclusive; > } > -- > 2.20.1.7.g153144c