From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85FDF1FBE for ; Sat, 5 Nov 2022 19:29:19 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id f7so12052811edc.6 for ; Sat, 05 Nov 2022 12:29:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L5WiDnJYUMPEroIJVQhoDLGCwGwQSDuzD60DQkwC21U=; b=XDXvj1FgNwwxOavSqI5F6MfzY3W7wZ6QiIBe4PadMQSGJ51QnDJV02SJYfmuS06uZO dxOBNd0gzXZsXLVJvFFnpS4MEJSE4O0GB63eokcPk+R+DPNvm7/XavHRBL+Q4VpnOMFE FR6d5yiFdt9lcSoG8hL4gIy+q0N5Dew8zx7ALRr5hy1buOBBI5CSiL+FAB3k3uNhPRKN 3oB6WxhQj8EUN9NQCV97Lgn47sfbCJhkWbHyuCiSJSGg1PL8X8NBQnx452UobkWdnDvA BlYMezSzkys4AxT6nLQS9AIiYYAzQ7te/JYys4eAdv6YN5gZBbLMljk1wlgZnFNIepRL N2fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L5WiDnJYUMPEroIJVQhoDLGCwGwQSDuzD60DQkwC21U=; b=KUwgGl/1eokBC7RcvBrD5XcJfbyeMx/bURkL+EqCCjmXcJrAO5A7DkTOom+UxtFJXL d/sOnGAobQ5HA2g7ZXsuvA6UixGPYYcgEKmk1B5pC3i2HydLG8q+yiOe82qbc1nULyEq VyBM5N+KdRypRNK0b9GCg62PEvCAsgKaz4czAH6BFX3CMuBnseniuEqNqEvI8tn90dob GRmIUoqI0fNhIFcdJZ3K0TVCxnT0fSIJJKEzoYUn41UX/6O3TfMtianf9bO9ADSux6Sd a003dsxrvCvNnFXXamkKqHCTvUCnkQMjZVIsDdOye38UNWllPHYBkLFHrjQ4pxP4PdXS MWcw== X-Gm-Message-State: ACrzQf18mqfIwbR/iUhfGOi0r1hotqwzYMtD+PRs7GcW7Of01AGq5kPl VpegVc1jgogEnp7oTLR+gf4= X-Google-Smtp-Source: AMsMyM5OwVk8D3AHxkt9RmUJOdie6sDw+sHJ8tcCbe0A/BYCweeCFTHh9v2l13vFBF21Ccdryh6pKA== X-Received: by 2002:a50:950d:0:b0:463:298a:448c with SMTP id u13-20020a50950d000000b00463298a448cmr35877817eda.153.1667676557640; Sat, 05 Nov 2022 12:29:17 -0700 (PDT) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id du1-20020a17090772c100b007812ba2a360sm1253482ejc.149.2022.11.05.12.29.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Nov 2022 12:29:17 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Samuel Holland Cc: Ivaylo Dimitrov , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Samuel Holland Subject: Re: [PATCH 1/2] bus: sunxi-rsb: Remove shutdown callback Date: Sat, 05 Nov 2022 20:29:15 +0100 Message-ID: <2652299.mvXUDI8C0e@jernej-laptop> In-Reply-To: <20221105191954.14360-2-samuel@sholland.org> References: <20221105191954.14360-1-samuel@sholland.org> <20221105191954.14360-2-samuel@sholland.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Dne sobota, 05. november 2022 ob 20:19:52 CET je Samuel Holland napisal(a): > Shutting down the RSB controller prevents communicating with a PMIC > inside pm_power_off(), so it breaks system poweroff on some boards. > > Reported-by: Ivaylo Dimitrov > Fixes: 843107498f91 ("bus: sunxi-rsb: Implement suspend/resume/shutdown > callbacks") Signed-off-by: Samuel Holland Acked-by: Jernej Skrabec Best regards, Jernej > --- > > drivers/bus/sunxi-rsb.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c > index 4cd2e127946e..17343cd75338 100644 > --- a/drivers/bus/sunxi-rsb.c > +++ b/drivers/bus/sunxi-rsb.c > @@ -812,14 +812,6 @@ static int sunxi_rsb_remove(struct platform_device > *pdev) return 0; > } > > -static void sunxi_rsb_shutdown(struct platform_device *pdev) > -{ > - struct sunxi_rsb *rsb = platform_get_drvdata(pdev); > - > - pm_runtime_disable(&pdev->dev); > - sunxi_rsb_hw_exit(rsb); > -} > - > static const struct dev_pm_ops sunxi_rsb_dev_pm_ops = { > SET_RUNTIME_PM_OPS(sunxi_rsb_runtime_suspend, > sunxi_rsb_runtime_resume, NULL) > @@ -835,7 +827,6 @@ MODULE_DEVICE_TABLE(of, sunxi_rsb_of_match_table); > static struct platform_driver sunxi_rsb_driver = { > .probe = sunxi_rsb_probe, > .remove = sunxi_rsb_remove, > - .shutdown = sunxi_rsb_shutdown, > .driver = { > .name = RSB_CTRL_NAME, > .of_match_table = sunxi_rsb_of_match_table,