From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44E63A32 for ; Fri, 12 May 2023 16:37:13 +0000 (UTC) Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-50bd37ca954so91296062a12.0 for ; Fri, 12 May 2023 09:37:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683909431; x=1686501431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QTY/iNPhSxqsOYVuVF5oPridnajCISLwpvB33cCStX4=; b=mQXoys12JvgdLa62LLYJLDzvL+tsH1KN3YfXhC27Z2LXWBDAyL4sAy6E0hG/t0xXtB AVAog6/+PYoXEq+ed3XdJqz2/jZ8xKjBID+qoLIW+tYcw+Nkkg9YeANhRjmh6ykQKPS7 VGwn/KRajhXuvvdVaZ+xxI0jS9XS9zHsVX0eLKfyGJrLjlsuUmGxgmKGJ0FOVrHh9Qg3 7qWI7PndkHVQAUgwyEduQJNWq5Uumwh06tB8TiJFMq6BwnRxIqhlKq4qs2Qi1WOwub6L FYybZIBV92FE15seZ946u1LrhcO/nVQIi7+XOAQWc4VbaUpVvfzWHH/Bkcnj5ESK9jEY IW8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683909431; x=1686501431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QTY/iNPhSxqsOYVuVF5oPridnajCISLwpvB33cCStX4=; b=GjzFgtAvof5wCc7gothpKQF+lEt7nEkhMWmLSiuz4OH9xtAo5JtEajULxreBgefelS M80lvDRR8LO+kwwmcBSJnHp2J5O498QV8B9kOYkvjyfgnqIYBArDcykdJeN+7qkDxAcu 6s5yF3e8KCSg/3uxRYeShBGCaSSN529AJcKrNzAFSXDUuy+KH/CeAAeZ+Qh3aEPm8+k5 XB5YObRhXQLBeggQalin2raD48AgCVgQcazngQcoxys8b2fO4loA+U5rCkiBCFhxSR6k F0fw832re7TAvLmsaZtOSAqBcV2C11oM3iDoKXP3ucId105bChZN6jz6Y7dQv5GZpDZm x1NQ== X-Gm-Message-State: AC+VfDxNLL/D0w1SQ3NHQgrJPcJH4KMzMSNqezsX3dZAgbmhpWq315jX +q61yEFTm5bKDDxelojoK1E= X-Google-Smtp-Source: ACHHUZ6oEr96mBEftUGvQgedCvHzktnamXm3QY6YaaVsVAMNVUmfiCMwnVR7gm8jofdWN5YF0zwLWA== X-Received: by 2002:a17:907:3e2a:b0:966:4973:b35 with SMTP id hp42-20020a1709073e2a00b0096649730b35mr17510063ejc.22.1683909431229; Fri, 12 May 2023 09:37:11 -0700 (PDT) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id gv28-20020a1709072bdc00b00965cfc209d5sm5619198ejc.8.2023.05.12.09.37.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 May 2023 09:37:10 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Jonathan McDowell Cc: Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , Linus Walleij , Bartosz Golaszewski , Conor Dooley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 5/5] ARM: dts: axp209: Add iio-hwmon node for internal temperature Date: Fri, 12 May 2023 18:37:09 +0200 Message-ID: <2679706.mvXUDI8C0e@jernej-laptop> In-Reply-To: References: <3421275.QJadu78ljV@jernej-laptop> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne petek, 12. maj 2023 ob 12:30:32 CEST je Jonathan McDowell napisal(a): > On Thu, May 11, 2023 at 06:11:49PM +0200, Jernej =C5=A0krabec wrote: > > Dne sreda, 10. maj 2023 ob 14:02:28 CEST je Jonathan McDowell napisal(a= ): > > > This adds a DT node to hook up the internal temperature ADC to the > > > iio-hwmon driver. The various voltage + current ADCs are consumed and > > > exposed by their respective drivers, but this is not and is always > > > available. Naming chosen to match the axp20x_ prefix the power sensors > > > use. > >=20 > > Sorry for maybe obvious thing, but where are other ADC channels exposed? >=20 > In the associated power drivers; e.g. axp20x_ac_power, axp20x_usb_power > + axp20x_battery. The internal temperature is the only one that > logically belongs to the chip as a whole rather than one of the > subfunctions. >=20 > root@chip:~# sensors > axp20x_battery-isa-0000 > Adapter: ISA adapter > in0: 0.00 V > curr1: 0.00 A >=20 > pmic_temp-isa-0000 > Adapter: ISA adapter > temp1: +42.5=C2=B0C >=20 > axp20x_ac-isa-0000 > Adapter: ISA adapter > in0: 0.00 V > curr1: 0.00 A >=20 > axp20x_usb-isa-0000 > Adapter: ISA adapter > in0: 4.93 V (min =3D +4.00 V) > curr1: 330.00 mA (max =3D +0.00 A) Right. Reviewed-by: Jernej Skrabec Best regards, Jernej >=20 > > > Signed-off-by: Jonathan McDowell > > > --- > > >=20 > > > arch/arm/boot/dts/axp209.dtsi | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > >=20 > > > diff --git a/arch/arm/boot/dts/axp209.dtsi > > > b/arch/arm/boot/dts/axp209.dtsi > > > index ca240cd6f6c3..469d0f7d5185 100644 > > > --- a/arch/arm/boot/dts/axp209.dtsi > > > +++ b/arch/arm/boot/dts/axp209.dtsi > > > @@ -48,6 +48,13 @@ > > >=20 > > > * http://dl.linux-sunxi.org/AXP/AXP209%20Datasheet%20v1.0_cn.pdf > > > */ > > >=20 > > > +/ { > > > + pmic-temp { > > > + compatible =3D "iio-hwmon"; > > > + io-channels =3D <&axp_adc 4>; /* Internal temperature */ > > > + }; > > > +}; > > > + > > >=20 > > > &axp209 { > > > =20 > > > compatible =3D "x-powers,axp209"; > > > interrupt-controller; >=20 > J.