From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C23AB10F9 for ; Tue, 24 Jan 2023 11:41:53 +0000 (UTC) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pKHfs-0007oa-LG; Tue, 24 Jan 2023 12:41:12 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Andreas =?ISO-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Alim Akhtar , Tony Huang , Li-hao Kuo , Maxime Ripard , Adrian Hunter , Masahiro Yamada , Markus Pargmann , Wolfram Sang , Jaehoon Chung , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-tegra@vger.kernel.org, linux-actions@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH 2/2] dt-bindings: mmc: correct pwrseq node names Date: Tue, 24 Jan 2023 12:41:10 +0100 Message-ID: <2739129.BEx9A2HvPv@diego> In-Reply-To: <955f4b2a-a750-11a2-0423-72023935723b@linaro.org> References: <20230120085722.171965-1-krzysztof.kozlowski@linaro.org> <2138388.Mh6RI2rZIc@diego> <955f4b2a-a750-11a2-0423-72023935723b@linaro.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Am Dienstag, 24. Januar 2023, 09:17:12 CET schrieb Krzysztof Kozlowski: > On 20/01/2023 10:38, Heiko St=FCbner wrote: > > Am Freitag, 20. Januar 2023, 09:57:22 CET schrieb Krzysztof Kozlowski: > >> Node names should be generic and should not contain underscores. > >> > >> Signed-off-by: Krzysztof Kozlowski > >> --- > >> Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml | 2 +- > >> Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml | 2 +- > >> Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 +- > >> 3 files changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yam= l b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml > >> index 911a5996e099..588be73168fa 100644 > >> --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml > >> +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml > >> @@ -41,7 +41,7 @@ additionalProperties: false > >> examples: > >> - | > >> #include > >> - sdhci0_pwrseq { > >> + pwrseq { > >=20 > > [applicable for all 3 examples] > >=20 > > hmm, power-sequences are not necessarily tied to an address and I guess > > it will be very much a common case to have multiple ones on a system. > >=20 > > So might it be better to follow other patterns (like leds) to number th= em > > or suggest a "foo-pwrseq" / "pwrseq-foo"? >=20 > In such cases one can add number or descriptive suffix (pwrseq-0, > pwrseq-foo), just like we do for regulators. However the examples have > here only one node and in such case "pwrseq" is enough. ok, when that is already part of the schema then all is fine :-) Reviewed-by: Heiko Stuebner