Re: [PATCH 144/173] ASoC: sunxi: sun8i-codec: Convert to platform remove callback returning void

Jernej Škrabec
2023-03-15T16:05:43Z

Dne sreda, 15. marec 2023 ob 16:07:16 CET je Uwe Kleine-König napisal(a):
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> ---
> sound/soc/sunxi/sun8i-codec.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/sunxi/sun8i-codec.c b/sound/soc/sunxi/sun8i-codec.c
> index 9844978d91e6..4c0d0d7d3e58 100644
> --- a/sound/soc/sunxi/sun8i-codec.c
> +++ b/sound/soc/sunxi/sun8i-codec.c
> @@ -1349,13 +1349,11 @@ static int sun8i_codec_probe(struct platform_device
> *pdev) return ret;
> }
>
> -static int sun8i_codec_remove(struct platform_device *pdev)
> +static void sun8i_codec_remove(struct platform_device *pdev)
> {
> pm_runtime_disable(&pdev->dev);
> if (!pm_runtime_status_suspended(&pdev->dev))
> sun8i_codec_runtime_suspend(&pdev->dev);
> -
> - return 0;
> }
>
> static const struct sun8i_codec_quirks sun8i_a33_quirks = {
> @@ -1385,7 +1383,7 @@ static struct platform_driver sun8i_codec_driver = {
> .pm = &sun8i_codec_pm_ops,
> },
> .probe = sun8i_codec_probe,
> - .remove = sun8i_codec_remove,
> + .remove_new = sun8i_codec_remove,
> };
> module_platform_driver(sun8i_codec_driver);