From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6A4313715 for ; Fri, 14 Jul 2023 19:38:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A62D9C433C8; Fri, 14 Jul 2023 19:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689363482; bh=fGJ6F5Ae/YFoT2UWCrLli9PCtviQD9Op8m1EXI3LXXU=; h=Date:Subject:List-Id:To:Cc:References:From:In-Reply-To:From; b=jYE5HJQE/PMLG3EMjSGfoDEwwkgTHcoohATsRj1fUayKeLvR07xfOCkIHjOGvykxm aip3QDRPq8Tte2DkfUmSHZYsHmLZJYvw4RHnWKjN7H2k5XufcmIyNXAFFJMVZrttGD RwkO5eJzf2pXSQ2UeEaJGCNH9HxiH5dE3rgoNoRCk/bpzPFDEAUAN4F2aWvXFzP6uF tvaRkjiJZkfD3yK3nyeb0QlgICDJAPAZxEupkfWlQU8Kq+ab2l8pDvgNxcFZ047/q1 vlJYGOonIcEBT5Vbwjoja/4Hd8/U5hzQGy29Oq3Jn4cYJW1LHKlpFNKSD0YpAjZmSP Vh/AAsrUwaumg== Message-ID: <2d001d37-90f8-4a44-5573-ea1667f44108@kernel.org> Date: Fri, 14 Jul 2023 14:37:52 -0500 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] clk: Explicitly include correct DT includes Content-Language: en-US List-Id: To: Rob Herring , Michael Turquette , Stephen Boyd , =?UTF-8?Q?Andreas_F=c3=a4rber?= , Manivannan Sadhasivam , Eugeniy Paltsev , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Joel Stanley , Andrew Jeffery , Neil Armstrong , Sudeep Holla , Cristian Marussi , Luca Ceresoli , Alex Helms , Abel Vesa , Peng Fan , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Nishanth Menon , Tero Kristo , Santosh Shilimkar , Matthias Brugger , AngeloGioacchino Del Regno , Jerome Brunet , Kevin Hilman , Martin Blumenstingl , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , Geert Uytterhoeven , Heiko Stuebner , Krzysztof Kozlowski , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Alim Akhtar , Palmer Dabbelt , Paul Walmsley , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Orson Zhai , Baolin Wang , Chunyan Zhang , Emil Renner Berthing , Hal Feng , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , =?UTF-8?Q?Emilio_L=c3=b3pez?= , Peter De Schrijver , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Michal Simek Cc: devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-oxnas@groups.io, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org References: <20230714174342.4052882-1-robh@kernel.org> From: Dinh Nguyen In-Reply-To: <20230714174342.4052882-1-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/14/23 12:43, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring > --- ... > drivers/clk/sifive/sifive-prci.c | 2 +- > drivers/clk/socfpga/clk-agilex.c | 3 +-- > drivers/clk/socfpga/clk-s10.c | 3 +-- For SoCFPGA Acked-by: Dinh Nguyen