From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47ACA20F2 for ; Mon, 31 Oct 2022 12:00:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667217627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HRPxwW2zKPepuA8PR9mUAwCAVRj8pp1PiT5CedYG760=; b=EmHVK/dquKgmZX0OO+/1qMJJhVG+5tnl95IqSY5Tpd9rH3ZME+xA/GEcOMFvCJZ+aloLjz o/+OVDyJEjWRpfMapiWWJXkZj+OF5DVn+SBzA6l+JDuJpzGpsy66my1PbJeZJTAZrrZDnH v4vxzAMiknuVDPysnCAlNOXsoUNr8rg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-98-R3bOBN88MLWcdWR6BPEaKw-1; Mon, 31 Oct 2022 08:00:25 -0400 X-MC-Unique: R3bOBN88MLWcdWR6BPEaKw-1 Received: by mail-wm1-f72.google.com with SMTP id m34-20020a05600c3b2200b003cf549cb32bso6148186wms.1 for ; Mon, 31 Oct 2022 05:00:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HRPxwW2zKPepuA8PR9mUAwCAVRj8pp1PiT5CedYG760=; b=iA5UzRCx7YpU1zmmOYfqLE3hVxpZ5TdMD3K3vIiQkJUh8CIINElZAg8B/qxSQ0GZyD GbdMAQ7y5lSKPnELVF3xXrGNMhe3Oh8BxUtPm3dvTVfDX1Q2l1xoSAIse/XlLxwS1ILO r7xkgFLUJ8peFNmxMDnkk7vSrhqJqyWrQFb1ixRdGsYRJIgsAAhVrNggXdWlsakyRPUB wAWAR1H6YAOAMTH+pPDeKeR4rkyxQUJBzO93WhlhVC8GbOm1mfrDPfwyfZ78xrqjJHS2 B8WqRMT+hqIaS+2831xKEkUSPCruzJPhQ1XY9yNbDXFI0huPOdbJBI/IbjCbKrRQCR4+ B2mw== X-Gm-Message-State: ACrzQf2jj+4Nlg7DnqoeO0qbmmE4li8Tqe/Oh+4qn7/N0UgeuGhjlkR1 vsx2iOYsQ2PpLPWn1GQozJN0Y1c4GCpb826pUCLQZ/sacSHrHtSo5XBHDWmqUPUzSUUzLwYTRHJ SqTYSNHS+7yRS3yNtA073Wsc= X-Received: by 2002:a5d:560e:0:b0:236:c325:4858 with SMTP id l14-20020a5d560e000000b00236c3254858mr4606542wrv.259.1667217623893; Mon, 31 Oct 2022 05:00:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7SGo+SId6me5X0r4rljOgpSC8TPNcKC+21wfNb2F4dclcZs6G1cIUREq2tk/ot5/dgyLJVEQ== X-Received: by 2002:a5d:560e:0:b0:236:c325:4858 with SMTP id l14-20020a5d560e000000b00236c3254858mr4606520wrv.259.1667217623655; Mon, 31 Oct 2022 05:00:23 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id bi19-20020a05600c3d9300b003c6c1686b10sm5388458wmb.7.2022.10.31.05.00.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 05:00:23 -0700 (PDT) Message-ID: <2e2e3915-a7b2-d030-2ffd-117b12deedb2@redhat.com> Date: Mon, 31 Oct 2022 13:00:21 +0100 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 03/21] drm/vboxvideo: Don't set struct drm_driver.lastclose To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-4-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-4-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/24/22 13:19, Thomas Zimmermann wrote: > Don't set struct drm_driver.lastclose. It's used to restore the > fbdev console. But as vboxvideo uses generic fbdev emulation, the > console is being restored by the DRM client helpers already. See > the call to drm_client_dev_restore() in drm_lastclose(). > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat