From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8326470 for ; Tue, 29 Jun 2021 17:03:44 +0000 (UTC) Received: by mail-wr1-f43.google.com with SMTP id a13so23129wrf.10 for ; Tue, 29 Jun 2021 10:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1mzwo7wjAUa0IJEbXNRwxkpgdnTr5r+kaQt26hfpS9Q=; b=QmmxT28DkHNzpao9vOpgiqd/+dJLsDibGQbrStNZ7JbAn0dorBqHkDj0WWKEfZk7OQ FNxBzNYYbYzgKsCZ0j18iEU1KtSxaIL4Fyk8uM4HCQ67154O4rhEmH9kLiuRXoOrC5q7 S624F07BLgYEYsvGXAHARz0QA4dg1CTiaNym2G/4ZRiWeANMPe2N15L3MveDp/WgRSYk IJA2nKKslgAsYg8dbGq8sMAXlDTQQYlDUbjGPAMWzEYVYvDRIOTDYXncAhpesbhqxL40 4Pb94hp2YdPRJ2JAMke+tMLiLTqa8JIZadNCDJ75yRoh9swK/MMMGXHQQBoAwR42SkSD djPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=1mzwo7wjAUa0IJEbXNRwxkpgdnTr5r+kaQt26hfpS9Q=; b=MmEWaC350UgrLJKaT6JQEx9kQR/THhaoBUY3zmPGPqN+z+2oOtd3+9Ssvybh48V8cw hzkU9/ooz9zFSugLp/I5vBC5BG9sfm2X8ZWIxSHpzKFIr4A1kCFh3pHbkBr/rsFZ1ieH xaGO7MLiQWH70UA0pganQ5Y8NsUZz8tEu5pRn2mOTOW1djZxrYppvZ283oouZPpJimbH 9+taTQUKU8p8XcorpQNjWIYBskleq6FJYnZHe9fHONeW19gUnGBY+/VPqVKckXQRQcin db3uLDMOxivtRgHDHRiI9k5/l2i89iK9jBhkeZsZiKSFs48aiPqyz40BVBclC3Hpz774 hRNA== X-Gm-Message-State: AOAM530Gj+bYYmsvpdSs70rjbKFX9PX9aQPYthiM6cg3KHCx+eixDBOv gBmJ05/J6s7/SAdAmkyrxvp1wQ== X-Google-Smtp-Source: ABdhPJw9BHdV2PhR+4EY9fQcITZ83GZhxsD5N3hVP1Z53THaNgNupwsLwr8mtFaReraEAQtYUI3qaQ== X-Received: by 2002:adf:ff8e:: with SMTP id j14mr34485328wrr.374.1624986222594; Tue, 29 Jun 2021 10:03:42 -0700 (PDT) Received: from ?IPv6:2001:861:44c0:66c0:9ed5:b63d:622c:fb4e? ([2001:861:44c0:66c0:9ed5:b63d:622c:fb4e]) by smtp.gmail.com with ESMTPSA id h10sm3399285wmb.40.2021.06.29.10.03.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Jun 2021 10:03:37 -0700 (PDT) Subject: Re: [PATCH] drm/aperture: Pass DRM driver structure instead of driver name To: Thomas Zimmermann , daniel@ffwll.ch, airlied@redhat.com Cc: linux-hyperv@vger.kernel.org, nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-rockchip@lists.infradead.org, amd-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, spice-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, freedreno@lists.freedesktop.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20210629135833.22679-1-tzimmermann@suse.de> From: Neil Armstrong Organization: Baylibre Message-ID: <32c2b8f1-e8e5-c161-ed87-f80190173552@baylibre.com> Date: Tue, 29 Jun 2021 19:03:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20210629135833.22679-1-tzimmermann@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 29/06/2021 15:58, Thomas Zimmermann wrote: > Print the name of the DRM driver when taking over fbdev devices. Makes > the output to dmesg more consistent. Note that the driver name is only > used for printing a string to the kernel log. No UAPI is affected by this > change. > > Signed-off-by: Thomas Zimmermann > --- ... > drivers/gpu/drm/meson/meson_drv.c | 2 +- Acked-by: Neil Armstrong ... > > diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c > index a7388bf7c838..3d0ccc7eef1b 100644 > --- a/drivers/gpu/drm/meson/meson_drv.c > +++ b/drivers/gpu/drm/meson/meson_drv.c > @@ -285,7 +285,7 @@ static int meson_drv_bind_master(struct device *dev, bool has_components) > * Remove early framebuffers (ie. simplefb). The framebuffer can be > * located anywhere in RAM > */ > - ret = drm_aperture_remove_framebuffers(false, "meson-drm-fb"); > + ret = drm_aperture_remove_framebuffers(false, &meson_driver); > if (ret) > goto free_drm; > ...