From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCEF17C for ; Sun, 24 Apr 2022 02:56:23 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id D4A205C00C1; Sat, 23 Apr 2022 22:56:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 23 Apr 2022 22:56:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1650768982; x= 1650855382; bh=JqFpsiVGIAqRWQSDW7yIX+O4lSdHSNm0rrFZT6Ixwzk=; b=p RJfM1mqWlNLsKFQNrKZqM7o54ZD21QXdlLkkXzN8F/Jdy+EK+caONMh/iPKtZI/H bWWjCPjLmY7+nTI2VigDYGqwYlPtYFuY8ZBKMIFaTzS+LDQZuJr/Q9KrVpGiQgIq KTiF9fzQr+COwuKnzx7XbsS7QtjBEcHbnCREqK1pIeN4wc70wI8qEpL7jKNdVFwP fMIiswpmDk8U9rPW6bMP8cHWWT4wp2JvnWp5ucA1lJV8M9GN4pVuCfNgRvyjwhT4 2lZA0E/IfJNXsGFVLmW/GmXRetDMvaMbvXnGnOzP/deEbm2er1s98bUt4N2y2q5e feUfCA9Oiymk88cjeWUpg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1650768982; x=1650855382; bh=JqFpsiVGIAqRW QSDW7yIX+O4lSdHSNm0rrFZT6Ixwzk=; b=tpAELAynGfIgkJqtYlb7wgHMu/p/n hQba1lB1iDhyUbWskeNLnXiyJDd+pF4m+JecrkKFMw+4FqsmWUe4sDqwEE93AYyD vPlZ/5khcZ3Xn8xDLEDJRqxrRZMrEk6VGzvKU1utwVkIs0btXWUj41+o06jbDnnZ blQwb9A1Kd2LcrVCkiBEIGqTpyWFpWl2x4Xzr8qKEfXLbv/N/NEQbTb/Qmzc6LIX YKMFkeLyH54mBmLZyZy8DnlPaws4ZOdsVxHTP6a/e0Afo0kHgopV1vCc0OXY1kNP fvMwa7BYIfSCgQ3sRMWZMr8VeX1HvRGlAm/FwOIlBmqa7XQQUGTbXdb/w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrtdejgdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefuvfevfhfhkffffgggjggtgfesthejredttdefjeenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepffdtveekvdegkeeuueetgfetffeileevudekuefhheelvdfhiedt heduhfduhefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshgrmhhuvghlsehshhholhhlrghnugdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 23 Apr 2022 22:56:22 -0400 (EDT) Subject: Re: [PATCH] arm64: dts: allwinner: teres-i: Add GPIO port regulators To: Harald Geyer , Chen-Yu Tsai , Jernej Skrabec Cc: linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, Torsten Duwe References: <20220415165605.28560-1-harald@ccbib.org> From: Samuel Holland Message-ID: <336f8b96-6eee-16a5-e896-e90c4020f740@sholland.org> Date: Sat, 23 Apr 2022 21:56:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20220415165605.28560-1-harald@ccbib.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/15/22 11:56 AM, Harald Geyer wrote: > Allwinner A64 SoC has separate supplies for PC, PD, PE, PG and PL. > > Usually supplies are linked via the 'regulator-name' property of > regulator nodes. However when regulators are shared we need to > declare the additional links in the pinctrl node. > > Signed-off-by: Harald Geyer I'm curious if this solved an issue for you, or if this is just for accuracy. Both of these regulators have the regulator-always-on property, so they should have been enabled already. If it's the latter reason, why not add the other ports? Regardless: Reviewed-by: Samuel Holland > --- > arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts > index aff0660b899c..cc316ef2e2d6 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts > @@ -197,6 +197,11 @@ &ohci1 { > status = "okay"; > }; > > +&pio { > + vcc-pc-supply = <®_dcdc1>; > + vcc-pg-supply = <®_aldo2>; > +}; > + > &pwm { > status = "okay"; > }; >